Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed paste value on server address selected #4954

Merged
merged 5 commits into from
Dec 19, 2022
Merged

Fixed paste value on server address selected #4954

merged 5 commits into from
Dec 19, 2022

Conversation

Machi3mfl
Copy link
Member

@Machi3mfl Machi3mfl commented Dec 2, 2022 •
edited
Loading

Hi Team,
This PR solves for this issue #4950

Related issue #4109

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Machi3mfl Machi3mfl requested a review from a team as a code owner December 2, 2022 15:59
@Machi3mfl Machi3mfl self-assigned this Dec 2, 2022
@Machi3mfl
Copy link
Member Author

How to test

  • Check if the value pasted in the WAZUH_MANAGER param is the IP
Peek.2022-12-02.09-22.mp4

@Machi3mfl Machi3mfl linked an issue Dec 2, 2022 that may be closed by this pull request
Deploy agent server address wrong pasted value #4950
Closed
Tostti
Tostti previously approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test: ✔️
CR: ✔️

Desvelao
Desvelao requested changes Dec 15, 2022
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review

  • Remove the worktree from the files changed
  • Add the pull request link to the changelog. As this pull request is a fix of a new feature, add the pull request link to the same entry of the feature

@Machi3mfl Machi3mfl requested a review from Desvelao December 15, 2022 16:51
@Machi3mfl
Copy link
Member Author

Machi3mfl commented Dec 16, 2022 •
edited
Loading

review

  • Remove the worktree from the files changed

  • Add the pull request link to the changelog. As this pull request is a fix of a new feature, add the pull request link to the same entry of the feature

Solved

@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 8.69% ( 3211 / 36960 )
Branches 4.43% ( 1271 / 28685 )
Functions 7.59% ( 696 / 9167 )
Lines 8.76% ( 3098 / 35380 )

@chantal-kelm chantal-kelm self-requested a review December 16, 2022 13:35
chantal-kelm
chantal-kelm approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

Evidence:

image

yenienserrano
yenienserrano approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image

@Desvelao Desvelao added the type/bug Bug issue label Dec 19, 2022
@Desvelao Desvelao merged commit 3b398cb into 4.4-7.10 Dec 19, 2022
@Desvelao Desvelao deleted the bugfix/4950-server-address-paste-ip branch December 19, 2022 13:00
github-actions bot pushed a commit that referenced this pull request Dec 19, 2022
@Machi3mfl @github-actions
Fixed paste value on server address selected (#4954)
9242827 
* Fixed paste value on server address selected

* Updated CHANGELOG

Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit 3b398cb)
This was referenced Dec 19, 2022
Merged
Merged
github-actions bot pushed a commit that referenced this pull request Dec 19, 2022
@Machi3mfl @github-actions
Fixed paste value on server address selected (#4954)
15326a8 
* Fixed paste value on server address selected

* Updated CHANGELOG

Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit 3b398cb)
Desvelao pushed a commit that referenced this pull request Dec 19, 2022
@github-actions @Machi3mfl
[Backport 4.4-7.16] Fixed paste value on server address selected (#5008)
93e4070 
Fixed paste value on server address selected (#4954)

* Fixed paste value on server address selected

* Updated CHANGELOG

Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit 3b398cb)

Co-authored-by: Maximiliano Ibarra <6089438+Machi3mfl@users.noreply.github.com>
Desvelao pushed a commit that referenced this pull request Dec 19, 2022
@github-actions @Machi3mfl
[Backport 4.4-2.4-wzd] Fixed paste value on server address selected (#…
35cc6c2 
…5009)

Fixed paste value on server address selected (#4954)

* Fixed paste value on server address selected

* Updated CHANGELOG

Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit 3b398cb)

Co-authored-by: Maximiliano Ibarra <6089438+Machi3mfl@users.noreply.github.com>
@Desvelao Desvelao mentioned this pull request Dec 20, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chantal-kelm chantal-kelm chantal-kelm approved these changes

@yenienserrano yenienserrano yenienserrano approved these changes

@Desvelao Desvelao Desvelao approved these changes

@Tostti Tostti Tostti left review comments

Assignees

@Machi3mfl Machi3mfl

Labels
type/bug Bug issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deploy agent server address wrong pasted value
6 participants
@Machi3mfl @Desvelao @Tostti @yenienserrano @chantal-kelm @AlexRuiz7