Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added file saving conditions in File Editor #4970

Merged
merged 3 commits into from
Dec 15, 2022
Merged

Added file saving conditions in File Editor #4970

merged 3 commits into from
Dec 15, 2022

Conversation

Machi3mfl
Copy link
Member

@Machi3mfl Machi3mfl commented Dec 7, 2022 •
edited
Loading

Description

This PR adds validations in the File Editor.

Issues Resolved

Closes #4946

Test

  • When the editor hasn't changed the initial content or is empty the "Save" button is disabled
Peek.2022-12-07.09-21.mp4
  • When the editor has a valid XML the "Save" button is enabled.
Peek.2022-12-07.09-24.mp4

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Machi3mfl Machi3mfl requested a review from a team as a code owner December 7, 2022 12:32
@Machi3mfl Machi3mfl changed the title Added File Editor validation before save Added File Editor validation to save file Dec 7, 2022
@Machi3mfl Machi3mfl changed the title Added File Editor validation to save file Added File Editor validation to save Dec 7, 2022
@Machi3mfl Machi3mfl changed the title Added File Editor validation to save Added file saving conditions in File Editor Dec 7, 2022
@Machi3mfl Machi3mfl self-assigned this Dec 7, 2022
@Machi3mfl Machi3mfl linked an issue Dec 7, 2022 that may be closed by this pull request
TypeError if empty rule is created #4946
Closed
Desvelao
Desvelao approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review

✔️ code
✔️ test

Screenshot
image

@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 8.69% ( 3210 / 36960 )
Branches 4.43% ( 1271 / 28688 )
Functions 7.59% ( 696 / 9168 )
Lines 8.75% ( 3097 / 35380 )

@chantal-kelm chantal-kelm self-requested a review December 15, 2022 11:24
chantal-kelm
chantal-kelm approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

Evidence

Grabacion.de.pantalla.2022-12-15.a.la.s.08.42.44.mov

@Machi3mfl Machi3mfl merged commit ec10fc7 into 4.4-7.10 Dec 15, 2022
@Machi3mfl Machi3mfl deleted the bugfix/4946-typeerror-rule-editor branch December 15, 2022 16:34
github-actions bot pushed a commit that referenced this pull request Dec 15, 2022
@Machi3mfl @github-actions
Added file saving conditions in File Editor (#4970)
1fc0c5b 
* Added Rule editor validation

* Updated CHANGELOG

Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit ec10fc7)
@github-actions github-actions bot mentioned this pull request Dec 15, 2022
Merged
github-actions bot pushed a commit that referenced this pull request Dec 15, 2022
@Machi3mfl @github-actions
Added file saving conditions in File Editor (#4970)
5ddb52b 
* Added Rule editor validation

* Updated CHANGELOG

Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit ec10fc7)
@github-actions github-actions bot mentioned this pull request Dec 15, 2022
Merged
Desvelao pushed a commit that referenced this pull request Dec 16, 2022
@github-actions @Machi3mfl
[Backport 4.4-7.16] Added file saving conditions in File Editor (#5002)
376e404 
Added file saving conditions in File Editor (#4970)

* Added Rule editor validation

* Updated CHANGELOG

Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit ec10fc7)

Co-authored-by: Maximiliano Ibarra <6089438+Machi3mfl@users.noreply.github.com>
@Desvelao Desvelao mentioned this pull request Dec 20, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chantal-kelm chantal-kelm chantal-kelm approved these changes

@Desvelao Desvelao Desvelao approved these changes

Assignees

@Machi3mfl Machi3mfl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError if empty rule is created
4 participants
@Machi3mfl @Desvelao @chantal-kelm @AlexRuiz7