-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix limit property in wazuh-api controller #4971
Merged
Desvelao
merged 3 commits into
4.4-2.4-wzd
from
fix/replace-status-code-constant-for-a-number-4969-4.4-2.3
Dec 14, 2022
Merged
Fix limit property in wazuh-api controller #4971
Desvelao
merged 3 commits into
4.4-2.4-wzd
from
fix/replace-status-code-constant-for-a-number-4969-4.4-2.3
Dec 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a-number-4969-4.4-2.3
|
Desvelao
approved these changes
Dec 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
review
✔️ code
✔️ test
I tested it by exporting to csv the rules in Manament/Rules and I got the rules.
Desvelao
deleted the
fix/replace-status-code-constant-for-a-number-4969-4.4-2.3
branch
December 14, 2022 16:08
github-actions bot
pushed a commit
that referenced
this pull request
Dec 14, 2022
* Fix limir property of request * Add changelog Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit 7d66538)
github-actions bot
pushed a commit
that referenced
this pull request
Dec 14, 2022
* Fix limir property of request * Add changelog Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit 7d66538)
Desvelao
added a commit
that referenced
this pull request
Dec 14, 2022
* Fix limit property in wazuh-api controller (#4971) * Fix limir property of request * Add changelog Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit 7d66538) * changelog: update the pr number Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com> Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com>
Desvelao
added a commit
that referenced
this pull request
Dec 14, 2022
* Fix limit property in wazuh-api controller (#4971) * Fix limir property of request * Add changelog Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit 7d66538) * changelog: update the pr number Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com> Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi team,
this PR fixes the problem that the number 500 of a request property was replaced with an HTTP status code constant.
Issues Resolved
#4969
Check List
yarn test:jest