Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors on closing flyouts in Firefox #5046

Merged
merged 3 commits into from
Jan 9, 2023
Merged

Fix errors on closing flyouts in Firefox #5046

merged 3 commits into from
Jan 9, 2023

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Dec 28, 2022 •
edited by AlexRuiz7
Loading

Description

This pull request fixes a problem when closing the flyouts using the Firefox browser.

Previously, we checked if the elements of the event.path contains the HTML classes related to the flyouts. The event.path is undefined for recent versions of Firefox browser, while others browsers could be defined and work the logic to close the flyout.

The solution removes the EuiOutsideClickDetector component wrapping to EuiFlyout. Now it uses the outsideClickCloses property of EuiFlyout.

The solution must work in all the browsers.

Issues Resolved

Closes #5043

Evidence

[Provide screenshots or videos to prove this PR solves the issues]

Test

For each browser (Google Chrome, Firefox, Safari)

Tests result template: pr_5046_template_result_tests.md

Scenario: Click inside of flyout of Integrity monitoring module should not display any errors in the browser console
When The user opens the flyout of the integrity monitoring module
And The user clicks inside the flyout
Then The browser console should not display any related errors

Scenario: Click outside of flyout of Integrity monitoring module should display any errors in the browser console
When The user opens the flyout of the integrity monitoring module
And The user clicks outside the flyout
Then the flyout should be closed without related errors

Scenario: Click inside of flyout of PCI DSS/Controls should not display errors in the browser console
When The user opens the flyout of the requirement in PCI DSS/Controls module
And The user clicks inside the flyout
Then The browser console should not display any related errors

Scenario: Click outside of flyout of PCI DSS/Controls should not display errors in the browser console
When The user opens the flyout of the requirement in PCI DSS/Controls module
And The user clicks outside the flyout
Then the flyout should be closed without related errors

Scenario: Click inside of flyout of GDPR/Controls should not display errors in the browser console
When The user opens the flyout of the requirement in GDPR/Controls module
And The user clicks inside the flyout
Then The browser console should not display any related errors

Scenario: Click outside of flyout of GDPR/Controls should not display errors in the browser console
When The user opens the flyout of the requirement in GDPR/Controls module
And The user clicks outside the flyout
Then the flyout should be closed without related errors

Scenario: Click inside of flyout of HIPAA/Controls should not display errors in the browser console
When The user opens the flyout of the requirement in HIPAA/Controls module
And The user clicks inside the flyout
Then The browser console should not display related errors

Scenario: Click outside of flyout of HIPAA/Controls should not display errors in the browser console
When The user opens the flyout of the requirement in HIPAA/Controls module
And The user clicks outside the flyout
Then the flyout should be closed without related errors

Scenario: Click inside of flyout of NIST 800-53/Controls should not display errors in the browser console
When The user opens the flyout of the requirement in NIST 800-53/Controls module
And The user clicks inside the flyout
Then The browser console should not display any related errors

Scenario: Click outside of flyout of NIST 800-53/Controls should not display errors in the browser console
When The user opens the flyout of the requirement in NIST 800-53/Controls module
And The user clicks outside the flyout
Then the flyout should be closed without related errors

Scenario: Click inside of flyout of TSC/Controls should not display errors in the browser console
When The user opens the flyout of the requirement in TSC/Controls module
And The user clicks inside the flyout
Then The browser console should not display any related errors

Scenario: Click outside of flyout of TSC/Controls should not display errors in the browser console
When The user opens the flyout of the requirement in TSC/Controls module
And The user clicks outside the flyout
Then the flyout should be closed without related errors

Scenario: Click inside of flyout of MITRE ATT&CK/Framework should not display errors in the browser console
When The user opens the flyout of the requirement in MITRE ATT&CK/Framework module
And The user clicks inside the flyout
Then The browser console should not display any related errors

Scenario: Click outside of flyout of MITRE ATT&CK/Framework should not display errors in the browser console
When The user opens the flyout of the requirement in MITRE ATT&CK/Framework module
And The user clicks outside the flyout
Then the flyout should be closed without related errors

Scenario: Click inside of flyout of Security/Users/Create user should not display errors in the browser console
When The user opens the flyout of the Security/Users/Create user
And The user clicks inside the flyout
Then The browser console should not display any related errors

Scenario: Click outside of flyout of Security/Users/Create user should not display errors in the browser console
When The user opens the flyout of the Security/Users/Create user
And The user clicks outside the flyout
Then the flyout should be closed without related errors

Scenario: Click outside of flyout of Security/Users/Create user should when there are no saved content should display the confirmation prompt. Cancel confirmation
When The user opens the flyout of the Security/Users/Create user
And The user clicks outside the flyout
Then A confirmation prompt should appear
And no related errors are displayed in the browser console
And The user clicks on the Cancel button
And no related errors are displayed in the browser console

Scenario: Click outside of flyout of Security/Users/Create user should when there are no saved content should display the confirmation prompt. Accept confirmation
When The user opens the flyout of the Security/Users/Create user
And The user clicks outside the flyout
Then A confirmation prompt should appear
And no related errors are displayed in the browser console
And The user clicks on the Aceept button
And no related errors are displayed in the browser console

Scenario: Click inside of flyout of Security/Users/Edit user should not display errors in the browser console
When The user opens the flyout of the Security/Users/Edit user
And The user clicks inside the flyout
Then The browser console should not display any related errors

Scenario: Click outside of flyout of Security/Users/Edit user should not display errors in the browser console
When The user opens the flyout of the Security/Users/Edit user
And The user clicks outside the flyout
Then the flyout should be closed without related errors

Scenario: Click outside of flyout of Security/Users/Edit user should when there are no saved content should display the confirmation prompt. Cancel confirmation
When The user opens the flyout of the Security/Users/Edit user
And The user clicks outside the flyout
Then A confirmation prompt should appear
And no related errors are displayed in the browser console
And The user clicks on the Cancel button
And no related errors are displayed in the browser console

Scenario: Click outside of flyout of Security/Users/Edit user should when there are no saved content should display the confirmation prompt. Accept confirmation
When The user opens the flyout of the Security/Users/Edit user
And The user clicks outside the flyout
Then A confirmation prompt should appear
And no related errors are displayed in the browser console
And The user clicks on the Cancel button
And no related errors are displayed in the browser console

Scenario: Click inside of flyout of Security/Policies/Create policy should not display errors in the browser console
When The user opens the flyout of the Security/Policies/Create policy
And The user clicks inside the flyout
Then The browser console should not display any related errors

Scenario: Click outside of flyout of Security/Policies/Create policy should not display errors in the browser console
When The user opens the flyout of the Security/Policies/Create policy
And The user clicks outside the flyout
Then the flyout should be closed without related errors

Scenario: Click outside of flyout of Security/Policies/Create policy should when there are no saved content should display the confirmation prompt. Cancel confirmation
When The user opens the flyout of the Security/Policies/Create policy
And The user clicks outside the flyout
Then A confirmation prompt should appear
And no related errors are displayed in the browser console
And The user clicks on the Cancel button
And no related errors are displayed in the browser console

Scenario: Click outside of flyout of Security/Policies/Create policy should when there are no saved content should display the confirmation prompt. Accept confirmation
When The user opens the flyout of the Security/Policies/Create policy
And The user clicks outside the flyout
Then A confirmation prompt should appear
And no related errors are displayed in the browser console
And The user clicks on the Accept button
And no related errors are displayed in the browser console

Scenario: Click inside of flyout of Security/Policies/Edit policy should not display errors in the browser console
When The user opens the flyout of the Security/Policies/Edit policy
And The user clicks inside the flyout
Then The browser console should not display any related errors

Scenario: Click outside of flyout of Security/Policies/Edit policy should not display errors in the browser console
When The user opens the flyout of the Security/Policies/Edit policy
And The user clicks outside the flyout
Then the flyout should be closed without related errors

Scenario: Click outside of flyout of Security/Policies/Edit policy should when there are no saved content should display the confirmation prompt. Cancel confirmation
When The user opens the flyout of the Security/Policies/Edit policy
And The user clicks outside the flyout
Then A confirmation prompt should appear
And no related errors are displayed in the browser console
And The user clicks on the Cancel button
And no related errors are displayed in the browser console

Scenario: Click outside of flyout of Security/Policies/Edit policy should when there are no saved content should display the confirmation prompt. Accept confirmation
When The user opens the flyout of the Security/Policies/Edit policy
And The user clicks outside the flyout
Then A confirmation prompt should appear
And no related errors are displayed in the browser console
And The user clicks on the Accept button
And no related errors are displayed in the browser console

Scenario: Click inside of flyout of Security/Roles/Create role should not display errors in the browser console
When The user opens the flyout of the Security/Roles/Create role
And The user clicks inside the flyout
Then The browser console should not display any related errors

Scenario: Click outside of flyout of Security/Roles/Create role should not display errors in the browser console
When The user opens the flyout of the Security/Roles/Create role
And The user clicks outside the flyout
Then the flyout should be closed without related errors

Scenario: Click outside of flyout of Security/Roles/Create role should when there are no saved content should display the confirmation prompt. Cancel confirmation
When The user opens the flyout of the Security/Roles/Create role
And The user clicks outside the flyout
Then A confirmation prompt should appear
And no related errors are displayed in the browser console
And The user clicks on the Cancel button
And no related errors are displayed in the browser console

Scenario: Click outside of flyout of Security/Roles/Create role should when there are no saved content should display the confirmation prompt. Accept confirmation
When The user opens the flyout of the Security/Roles/Create role
And The user clicks outside the flyout
Then A confirmation prompt should appear
And no related errors are displayed in the browser console
And The user clicks on the Accept button
And no related errors are displayed in the browser console

Scenario: Click inside of flyout of Security/Roles/Edit role should not display errors in the browser console
When The user opens the flyout of the Security/Roles/Edit role
And The user clicks inside the flyout
Then The browser console should not display any related errors

Scenario: Click outside of flyout of Security/Roles/Edit role should not display errors in the browser console
When The user opens the flyout of the Security/Roles/Edit role
And The user clicks outside the flyout
Then the flyout should be closed without related errors

Scenario: Click outside of flyout of Security/Roles/Edit role should when there are no saved content should display the confirmation prompt. Cancel confirmation
When The user opens the flyout of the Security/Roles/Edit role
And The user clicks outside the flyout
Then A confirmation prompt should appear
And no related errors are displayed in the browser console
And The user clicks on the Cancel button
And no related errors are displayed in the browser console

Scenario: Click outside of flyout of Security/Roles/Edit role should when there are no saved content should display the confirmation prompt. Accept confirmation
When The user opens the flyout of the Security/Roles/Edit role
And The user clicks outside the flyout
Then A confirmation prompt should appear
And no related errors are displayed in the browser console
And The user clicks on the Accept button
And no related errors are displayed in the browser console

Scenario: Click inside of flyout of Security/Role mapping/Create role mapping should not display errors in the browser console
When The user opens the flyout of the Security/Role mapping/Create role mapping
And The user clicks inside the flyout
Then The browser console should not display any related errors

Scenario: Click outside of flyout of Security/Role mapping/Create role mapping should not display errors in the browser console
When The user opens the flyout of the Security/Role mapping/Create role mapping
And The user clicks outside the flyout
Then the flyout should be closed without related errors

Scenario: Click outside of flyout of Security/Role mapping/Create role mapping should when there are no saved content should display the confirmation prompt. Cancel confirmation
When The user opens the flyout of the Security/Role mapping/Create role mapping
And The user clicks outside the flyout
Then A confirmation prompt should appear
And no related errors are displayed in the browser console
And The user clicks on the Cancel button
And no related errors are displayed in the browser console

Scenario: Click outside of flyout of Security/Role mapping/Create role mapping should when there are no saved content should display the confirmation prompt. Accept confirmation
When The user opens the flyout of the Security/Role mapping/Create role mapping
And The user clicks outside the flyout
Then A confirmation prompt should appear
And no related errors are displayed in the browser console
And The user clicks on the Accept button
And no related errors are displayed in the browser console

Scenario: Click inside of flyout of Security/Role mapping/Edit role mapping should not display errors in the browser console
When The user opens the flyout of the Security/Role mapping/Edit role mapping
And The user clicks inside the flyout
Then The browser console should not display any related errors

Scenario: Click outside of flyout of Security/Role mapping/Edit role mapping should not display errors in the browser console
When The user opens the flyout of the Security/Role mapping/Edit role mapping
And The user clicks outside the flyout
Then the flyout should be closed without related errors

Scenario: Click outside of flyout of Security/Role mapping/Edit role mapping should when there are no saved content should display the confirmation prompt. Cancel confirmation
When The user opens the flyout of the Security/Role mapping/Edit role mapping
And The user clicks outside the flyout
Then A confirmation prompt should appear
And no related errors are displayed in the browser console
And The user clicks on the Cancel button
And no related errors are displayed in the browser console

Scenario: Click outside of flyout of Security/Role mapping/Edit role mapping should when there are no saved content should display the confirmation prompt. Accept confirmation
When The user opens the flyout of the Security/Role mapping/Edit role mapping
And The user clicks outside the flyout
Then A confirmation prompt should appear
And no related errors are displayed in the browser console
And The user clicks on the Accept button
And no related errors are displayed in the browser console

Scenario: Click inside of flyout of rule details in Management/Rules should not display errors in the browser console
When The user opens the flyout of rule details in Management/Rules
And The user clicks inside the flyout
Then The browser console should not display any related errors

Scenario: Click outside of flyout of rule details in Management/Rules should not display errors in the browser console
When The user opens the flyout of rule details in Management/Rules
And The user clicks outside the flyout
Then the flyout should be closed without related errors

Scenario: Click inside of flyout of decoder details in Management/Decoders should not display errors in the browser console
When The user opens the flyout of rule details in Management/Decoders
And The user clicks inside the flyout
Then The browser console should not display any related errors

Scenario: Click outside of flyout of decoder details in Management/Decoders should not display errors in the browser console
When The user opens the flyout of rule details in Management/Decoders
And The user clicks outside the flyout
Then the flyout should be closed without related errors

Scenario: Click inside of flyout of Ruleset Test when creating a new rule file in Management/Rules should not display errors in the browser console
When The user opens the flyout of Ruleset Test when creating a new rule file in Management/Rules
And The user clicks inside the flyout
Then The browser console should not display any related errors

Scenario: Click outside of flyout of Ruleset Test when creating a new rule file in Management/Rules should not display errors in the browser console
When The user opens the flyout of Ruleset Test when creating a new rule file in Management/Rules
And The user clicks outside the flyout
Then the flyout should be closed without related errors

Scenario: Click inside of flyout of Ruleset Test when creating a new decoder file in Management/Decoders should not display errors in the browser console
When The user opens the flyout of Ruleset Test when creating a new decoder file in Management/Decoders
And The user clicks inside the flyout
Then The browser console should not display any related errors

Scenario: Click outside of flyout of Ruleset Test when creating a new decoder file in Management/Decoders should not display errors in the browser console
When The user opens the flyout of Ruleset Test when creating a new decoder file in Management/Decoders
And The user clicks outside the flyout
Then the flyout should be closed without related errors

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Desvelao
fix: fix error closing the flyouts in Firefox
38cad04 
Removed the logic using the undefined `event.path` in Firefox.

Removed EuiOutsideClickDetector component wrapping to EuiFlyout. Now it uses the
outSideClickCloses property of EuiFlyout.

This solution must work in all the browsers.
@Desvelao Desvelao requested a review from a team as a code owner December 28, 2022 11:46
@Desvelao Desvelao self-assigned this Dec 28, 2022
@Desvelao Desvelao added the type/bug Bug issue label Dec 28, 2022
@yenienserrano
Copy link
Member

yenienserrano commented Dec 28, 2022 •
edited
Loading

Wazuh dashboard

Legend:
⚫: none
🟢: passed
🔴: failed
🟡: warning
⚪: not applicable

Test Chrome Firefox Safari Package
Click inside of flyout of Integrity monitoring module should not display any errors in the browser console ⚫ ⚫ ⚫ WZD
Click outside of flyout of Integrity monitoring module should display any errors in the browser console ⚫ ⚫ ⚫ WZD
Click inside of flyout of PCI DSS/Controls should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of PCI DSS/Controls should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click inside of flyout of GDPR/Controls should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of GDPR/Controls should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click inside of flyout of HIPAA/Controls should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of HIPAA/Controls should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click inside of flyout of NIST 800-53/Controls should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of NIST 800-53/Controls should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click inside of flyout of TSC/Controls should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of TSC/Controls should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click inside of flyout of MITRE ATT&CK/Framework should not display errors in the browser console ⚫ ⚫ ⚫ WZD
Click outside of flyout of MITRE ATT&CK/Framework should not display errors in the browser console ⚫ ⚫ ⚫ WZD
Click inside of flyout of Security/Users/Create user should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Users/Create user should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Users/Create user should when there are no saved content should display the confirmation prompt. Cancel confirmation 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Users/Create user should when there are no saved content should display the confirmation prompt. Accept confirmation 🟢 🟢 ⚫ WZD
Click inside of flyout of Security/Users/Edit user should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Users/Edit user should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Users/Edit user should when there are no saved content should display the confirmation prompt. Cancel confirmation 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Users/Edit user should when there are no saved content should display the confirmation prompt. Accept confirmation 🟢 🟢 ⚫ WZD
Click inside of flyout of Security/Policies/Create policy should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Policies/Create policy should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Policies/Create policy should when there are no saved content should display the confirmation prompt. Cancel confirmation 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Policies/Create policy should when there are no saved content should display the confirmation prompt. Accept confirmation 🟢 🟢 ⚫ WZD
Click inside of flyout of Security/Policies/Edit policy should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Policies/Edit policy should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Policies/Edit policy should when there are no saved content should display the confirmation prompt. Cancel confirmation 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Policies/Edit policy should when there are no saved content should display the confirmation prompt. Accept confirmation 🟢 🟢 ⚫ WZD
Click inside of flyout of Security/Roles/Create role should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Roles/Create role should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Roles/Create role should when there are no saved content should display the confirmation prompt. Cancel confirmation 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Roles/Create role should when there are no saved content should display the confirmation prompt. Accept confirmation 🟢 🟢 ⚫ WZD
Click inside of flyout of Security/Roles/Edit role should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Roles/Edit role should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Roles/Edit role should when there are no saved content should display the confirmation prompt. Cancel confirmation 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Roles/Edit role should when there are no saved content should display the confirmation prompt. Accept confirmation 🟢 🟢 ⚫ WZD
Click inside of flyout of Security/Role mapping/Create role mapping should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Role mapping/Create role mapping should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Role mapping/Create role mapping should when there are no saved content should display the confirmation prompt. Cancel confirmation 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Role mapping/Create role mapping should when there are no saved content should display the confirmation prompt. Accept confirmation 🟢 🟢 ⚫ WZD
Click inside of flyout of Security/Role mapping/Edit role mapping should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Role mapping/Edit role mapping should not display errors in the browser console 🟢 🟢 ⚫ WZD
Scenario: Click outside of flyout of Security/Role mapping/Edit role mapping should when there are no saved content should display the confirmation prompt. Cancel confirmation 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Role mapping/Edit role mapping should when there are no saved content should display the confirmation prompt. Accept confirmation 🟢 🟢 ⚫ WZD
Click inside of flyout of rule details in Management/Rules should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of rule details in Management/Rules should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click inside of flyout of decoder details in Management/Decoders should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of decoder details in Management/Decoders should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click inside of flyout of Ruleset Test when creating a new rule file in Manament/Rules should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of Ruleset Test when creating a new rule file in Manament/Rules should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click inside of flyout of Ruleset Test when creating a new decoder file in Manament/Decoders should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of Ruleset Test when creating a new decoder file in Manament/Decoders should not display errors in the browser console 🟢 🟢 ⚫ WZD

Details

⚫ Click inside of flyout of Integrity monitoring module should not display any errors in the browser console

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Click outside of flyout of Integrity monitoring module should display any errors in the browser console

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

🟢 Click inside of flyout of PCI DSS/Controls should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of PCI DSS/Controls should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click inside of flyout of GDPR/Controls should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of GDPR/Controls should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click inside of flyout of HIPAA/Controls should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of HIPAA/Controls should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click inside of flyout of NIST 800-53/Controls should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of NIST 800-53/Controls should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click inside of flyout of TSC/Controls should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of TSC/Controls should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

⚫ Click inside of flyout of MITRE ATT&CK/Framework should not display errors in the browser console

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Click outside of flyout of MITRE ATT&CK/Framework should not display errors in the browser console

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

🟢 Click inside of flyout of Security/Users/Create user should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of Security/Users/Create user should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of Security/Users/Create user should when there are no saved content should display the confirmation prompt. Cancel confirmation

Chrome - 🟢

image
image

Firefox - 🟢

image
image

Safari - ⚫

🟢 Click outside of flyout of Security/Users/Create user should when there are no saved content should display the confirmation prompt. Accept confirmation

Chrome - 🟢

image
image

Firefox - 🟢

image
image

Safari - ⚫

🟢 Click inside of flyout of Security/Users/Edit user should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of Security/Users/Edit user should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of Security/Users/Edit user should when there are no saved content should display the confirmation prompt. Cancel confirmation

Chrome - 🟢

image
image

Firefox - 🟢

image
image

Safari - ⚫

🟢 Click outside of flyout of Security/Users/Edit user should when there are no saved content should display the confirmation prompt. Accept confirmation

Chrome - 🟢

image
image

Firefox - 🟢

image
image

Safari - ⚫

🟢 Click inside of flyout of Security/Policies/Create policy should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of Security/Policies/Create policy should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of Security/Policies/Create policy should when there are no saved content should display the confirmation prompt. Cancel confirmation

Chrome - 🟢

image
image

Firefox - 🟢

image
image

Safari - ⚫

🟢 Click outside of flyout of Security/Policies/Create policy should when there are no saved content should display the confirmation prompt. Accept confirmation

Chrome - 🟢

image
image

Firefox - 🟢

image
image

Safari - ⚫

🟢 Click inside of flyout of Security/Policies/Edit policy should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of Security/Policies/Edit policy should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of Security/Policies/Edit policy should when there are no saved content should display the confirmation prompt. Cancel confirmation

Chrome - 🟢

image
image

Firefox - 🟢

image
image

Safari - ⚫

🟢 Click outside of flyout of Security/Policies/Edit policy should when there are no saved content should display the confirmation prompt. Accept confirmation

Chrome - 🟢

image
image

Firefox - 🟢

image
image

Safari - ⚫

🟢 Click inside of flyout of Security/Roles/Create role should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of Security/Roles/Create role should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of Security/Roles/Create role should when there are no saved content should display the confirmation prompt. Cancel confirmation

Chrome - 🟢

image
image

Firefox - 🟢

image
image

Safari - ⚫

🟢 Click outside of flyout of Security/Roles/Create role should when there are no saved content should display the confirmation prompt. Accept confirmation

Chrome - 🟢

image
image

Firefox - 🟢

image
image

Safari - ⚫

🟢 Click inside of flyout of Security/Roles/Edit role should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of Security/Roles/Edit role should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of Security/Roles/Edit role should when there are no saved content should display the confirmation prompt. Cancel confirmation

Chrome - 🟢

image
image

Firefox - 🟢

image
image

Safari - ⚫

🟢 Click outside of flyout of Security/Roles/Edit role should when there are no saved content should display the confirmation prompt. Accept confirmation

Chrome - 🟢

image
image

Firefox - 🟢

image
image

Safari - ⚫

🟢 Click inside of flyout of Security/Role mapping/Create role mapping should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of Security/Role mapping/Create role mapping should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of Security/Role mapping/Create role mapping should when there are no saved content should display the confirmation prompt. Cancel confirmation

Chrome - 🟢

image
image

Firefox - 🟢

image
image

Safari - ⚫

🟢 Click outside of flyout of Security/Role mapping/Create role mapping should when there are no saved content should display the confirmation prompt. Accept confirmation

Chrome - 🟢

image
image

Firefox - 🟢

image
image

Safari - ⚫

🟢 Click inside of flyout of Security/Role mapping/Edit role mapping should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of Security/Role mapping/Edit role mapping should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 **Scenario**: Click outside of flyout of Security/Role mapping/Edit role mapping should when there are no saved content should display the confirmation prompt. Cancel confirmation

Chrome - 🟢

image
image

Firefox - 🟢

image
image

Safari - ⚫

🟢 Click outside of flyout of Security/Role mapping/Edit role mapping should when there are no saved content should display the confirmation prompt. Accept confirmation

Chrome - 🟢

image
image

Firefox - 🟢

image
image

Safari - ⚫

🟢 Click inside of flyout of rule details in Management/Rules should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of rule details in Management/Rules should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click inside of flyout of decoder details in Management/Decoders should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of decoder details in Management/Decoders should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click inside of flyout of Ruleset Test when creating a new rule file in Manament/Rules should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of Ruleset Test when creating a new rule file in Manament/Rules should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click inside of flyout of Ruleset Test when creating a new decoder file in Manament/Decoders should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of Ruleset Test when creating a new decoder file in Manament/Decoders should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

@Desvelao Desvelao linked an issue Dec 28, 2022 that may be closed by this pull request
Uncaught TypeError ev.path is undefined #5043
Closed
@Desvelao Desvelao mentioned this pull request Dec 28, 2022
Closed
yenienserrano
yenienserrano approved these changes Dec 28, 2022
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

Comment

Some flyouts lose focus when clicked on inside

Screenshots

with focus
image
image
image

without focus
image
image
image

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

Code coverage (Jest) % values
Statements 8.69% ( 3210 / 36933 )
Branches 4.53% ( 1300 / 28676 )
Functions 7.55% ( 692 / 9155 )
Lines 8.75% ( 3097 / 35366 )

@Tostti
Copy link
Member

Tostti commented Jan 5, 2023

Wazuh dashboard

Legend:
⚫: none
🟢: passed
🔴: failed
🟡: warning
⚪: not applicable

Test Chrome Firefox Safari Package
Click inside of flyout of Integrity monitoring module should not display any errors in the browser console ⚫ ⚫ ⚫ WZD
Click outside of flyout of Integrity monitoring module should display any errors in the browser console ⚫ ⚫ ⚫ WZD
Click inside of flyout of PCI DSS/Controls should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of PCI DSS/Controls should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click inside of flyout of GDPR/Controls should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of GDPR/Controls should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click inside of flyout of HIPAA/Controls should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of HIPAA/Controls should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click inside of flyout of NIST 800-53/Controls should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of NIST 800-53/Controls should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click inside of flyout of TSC/Controls should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of TSC/Controls should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click inside of flyout of MITRE ATT&CK/Framework should not display errors in the browser console ⚫ ⚫ ⚫ WZD
Click outside of flyout of MITRE ATT&CK/Framework should not display errors in the browser console ⚫ ⚫ ⚫ WZD
Click inside of flyout of Security/Users/Create user should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Users/Create user should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Users/Create user should when there are no saved content should display the confirmation prompt. Cancel confirmation 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Users/Create user should when there are no saved content should display the confirmation prompt. Accept confirmation 🟢 🟢 ⚫ WZD
Click inside of flyout of Security/Users/Edit user should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Users/Edit user should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Users/Edit user should when there are no saved content should display the confirmation prompt. Cancel confirmation 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Users/Edit user should when there are no saved content should display the confirmation prompt. Accept confirmation 🟢 🟢 ⚫ WZD
Click inside of flyout of Security/Policies/Create policy should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Policies/Create policy should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Policies/Create policy should when there are no saved content should display the confirmation prompt. Cancel confirmation 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Policies/Create policy should when there are no saved content should display the confirmation prompt. Accept confirmation 🟢 🟢 ⚫ WZD
Click inside of flyout of Security/Policies/Edit policy should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Policies/Edit policy should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Policies/Edit policy should when there are no saved content should display the confirmation prompt. Cancel confirmation 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Policies/Edit policy should when there are no saved content should display the confirmation prompt. Accept confirmation 🟢 🟢 ⚫ WZD
Click inside of flyout of Security/Roles/Create role should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Roles/Create role should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Roles/Create role should when there are no saved content should display the confirmation prompt. Cancel confirmation 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Roles/Create role should when there are no saved content should display the confirmation prompt. Accept confirmation 🟢 🟢 ⚫ WZD
Click inside of flyout of Security/Roles/Edit role should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Roles/Edit role should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Roles/Edit role should when there are no saved content should display the confirmation prompt. Cancel confirmation ⚫ ⚫ ⚫ WZD
Click outside of flyout of Security/Roles/Edit role should when there are no saved content should display the confirmation prompt. Accept confirmation ⚫ ⚫ ⚫ WZD
Click inside of flyout of Security/Role mapping/Create role mapping should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Role mapping/Create role mapping should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Role mapping/Create role mapping should when there are no saved content should display the confirmation prompt. Cancel confirmation 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Role mapping/Create role mapping should when there are no saved content should display the confirmation prompt. Accept confirmation 🟢 🟢 ⚫ WZD
Click inside of flyout of Security/Role mapping/Edit role mapping should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Role mapping/Edit role mapping should not display errors in the browser console 🟢 🟢 ⚫ WZD
Scenario: Click outside of flyout of Security/Role mapping/Edit role mapping should when there are no saved content should display the confirmation prompt. Cancel confirmation 🟢 🟢 ⚫ WZD
Click outside of flyout of Security/Role mapping/Edit role mapping should when there are no saved content should display the confirmation prompt. Accept confirmation 🟢 🟢 ⚫ WZD
Click inside of flyout of rule details in Management/Rules should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of rule details in Management/Rules should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click inside of flyout of decoder details in Management/Decoders should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of decoder details in Management/Decoders should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click inside of flyout of Ruleset Test when creating a new rule file in Manament/Rules should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of Ruleset Test when creating a new rule file in Manament/Rules should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click inside of flyout of Ruleset Test when creating a new decoder file in Manament/Decoders should not display errors in the browser console 🟢 🟢 ⚫ WZD
Click outside of flyout of Ruleset Test when creating a new decoder file in Manament/Decoders should not display errors in the browser console 🟢 🟢 ⚫ WZD

Details

⚫ Click inside of flyout of Integrity monitoring module should not display any errors in the browser console

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Click outside of flyout of Integrity monitoring module should display any errors in the browser console

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

🟢 Click inside of flyout of PCI DSS/Controls should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢
image

Safari - ⚫

🟢 Click outside of flyout of PCI DSS/Controls should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click inside of flyout of GDPR/Controls should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of GDPR/Controls should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click inside of flyout of HIPAA/Controls should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of HIPAA/Controls should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click inside of flyout of NIST 800-53/Controls should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of NIST 800-53/Controls should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click inside of flyout of TSC/Controls should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of TSC/Controls should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

⚫ Click inside of flyout of MITRE ATT&CK/Framework should not display errors in the browser console

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Click outside of flyout of MITRE ATT&CK/Framework should not display errors in the browser console

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

🟢 Click inside of flyout of Security/Users/Create user should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of Security/Users/Create user should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of Security/Users/Create user should when there are no saved content should display the confirmation prompt. Cancel confirmation

Chrome - 🟢

image

image

Firefox - 🟢

image
image

Safari - ⚫

🟢 Click outside of flyout of Security/Users/Create user should when there are no saved content should display the confirmation prompt. Accept confirmation

Chrome - 🟢

image
image

Firefox - 🟢

image
image

Safari - ⚫

🟢 Click inside of flyout of Security/Users/Edit user should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of Security/Users/Edit user should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of Security/Users/Edit user should when there are no saved content should display the confirmation prompt. Cancel confirmation

Chrome - 🟢

image
image

Firefox - 🟢

image
image

Safari - ⚫

🟢 Click outside of flyout of Security/Users/Edit user should when there are no saved content should display the confirmation prompt. Accept confirmation

Chrome - 🟢

image
image

Firefox - 🟢

image
image

Safari - ⚫

🟢 Click inside of flyout of Security/Policies/Create policy should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of Security/Policies/Create policy should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of Security/Policies/Create policy should when there are no saved content should display the confirmation prompt. Cancel confirmation

Chrome - 🟢

image
image

Firefox - 🟢

image
image

Safari - ⚫

🟢 Click outside of flyout of Security/Policies/Create policy should when there are no saved content should display the confirmation prompt. Accept confirmation

Chrome - 🟢

image
image

Firefox - 🟢

image
image

Safari - ⚫

🟢 Click inside of flyout of Security/Policies/Edit policy should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of Security/Policies/Edit policy should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of Security/Policies/Edit policy should when there are no saved content should display the confirmation prompt. Cancel confirmation

Chrome - 🟢

image
image

Firefox - 🟢

image
image

Safari - ⚫

🟢 Click outside of flyout of Security/Policies/Edit policy should when there are no saved content should display the confirmation prompt. Accept confirmation

Chrome - 🟢

image
image

Firefox - 🟢

image
image

Safari - ⚫

🟢 Click inside of flyout of Security/Roles/Create role should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of Security/Roles/Create role should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of Security/Roles/Create role should when there are no saved content should display the confirmation prompt. Cancel confirmation

Chrome - 🟢

image
image

Firefox - 🟢

image
image

Safari - ⚫

🟢 Click outside of flyout of Security/Roles/Create role should when there are no saved content should display the confirmation prompt. Accept confirmation

Chrome - 🟢

image
image

Firefox - 🟢

image
image

Safari - ⚫

🟢 Click inside of flyout of Security/Roles/Edit role should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of Security/Roles/Edit role should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

⚫ Click outside of flyout of Security/Roles/Edit role should when there are no saved content should display the confirmation prompt. Cancel confirmation

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Click outside of flyout of Security/Roles/Edit role should when there are no saved content should display the confirmation prompt. Accept confirmation

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

🟢 Click inside of flyout of Security/Role mapping/Create role mapping should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of Security/Role mapping/Create role mapping should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of Security/Role mapping/Create role mapping should when there are no saved content should display the confirmation prompt. Cancel confirmation

Chrome - 🟢

image
image

Firefox - 🟢

image
image

Safari - ⚫

🟢 Click outside of flyout of Security/Role mapping/Create role mapping should when there are no saved content should display the confirmation prompt. Accept confirmation

Chrome - 🟢

image
image

Firefox - 🟢

image
image

Safari - ⚫

🟢 Click inside of flyout of Security/Role mapping/Edit role mapping should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of Security/Role mapping/Edit role mapping should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of Security/Role mapping/Edit role mapping should when there are no saved content should display the confirmation prompt. Cancel confirmation

Chrome - 🟢

image
image

Firefox - 🟢

image
image

Safari - ⚫

🟢 Click outside of flyout of Security/Role mapping/Edit role mapping should when there are no saved content should display the confirmation prompt. Accept confirmation

Chrome - 🟢

image
image

Firefox - 🟢

image
image

Safari - ⚫

🟢 Click inside of flyout of rule details in Management/Rules should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of rule details in Management/Rules should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click inside of flyout of decoder details in Management/Decoders should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of decoder details in Management/Decoders should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click inside of flyout of Ruleset Test when creating a new rule file in Management/Rules should not display errors in the browser console

Chrome - 🟢

image
Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of Ruleset Test when creating a new rule file in Manament/Rules should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click inside of flyout of Ruleset Test when creating a new decoder file in Manament/Decoders should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Click outside of flyout of Ruleset Test when creating a new decoder file in Manament/Decoders should not display errors in the browser console

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

Tostti
Tostti approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

LGTM

@AlexRuiz7 AlexRuiz7 merged commit bee5a73 into 4.4-2.4-wzd Jan 9, 2023
@AlexRuiz7 AlexRuiz7 deleted the fix/5043-click-on-flyouts-give-errors-firefox branch January 9, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenienserrano yenienserrano yenienserrano approved these changes

@Tostti Tostti Tostti approved these changes

Assignees

@Desvelao Desvelao

Labels
type/bug Bug issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uncaught TypeError ev.path is undefined
5 participants
@Desvelao @yenienserrano @Tostti @AlexRuiz7 @chantal-kelm