Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.4] Add Alerts summary and Last alerts definitions in PDF reports #5071

Conversation

asteriscos
Copy link
Member

Description

This PR adds missing Alerts summary and Last alerts tables definitions to PDF reports. It also fixes a missing field issue when a particular field doesn't have a value.

Issues Resolved

Closes #5044

Evidence

PCI DSS Agent PDF report
Screenshot from 2022-12-30 18-16-18

Osquery Agent PDF report
Screenshot from 2022-12-30 18-14-21

Test

Generate a report of each module with and without a pinned agent.
Pending definition of each test.

Security Information Management

Module With pinned agent Without agent
Security events
Integrity monitoring
Office 365
Amazon AWS
Google Cloud Platform
GitHub

Auditing and Policy Monitoring

Module With pinned agent Without agent
Policy monitoring
Security configuration assessment
System auditing
OpenSCAP
CIS-CAT

Threat Detection and Response

Module With pinned agent Without agent
Vulnerabilities
MITRE ATT&CK
VirusTotal
Osquery
Docker listener

Regulatory Compliance

Module With pinned agent Without agent
PCI DSS
NIST 800-53
GDPR
HIPAA
TSC

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos requested a review from a team as a code owner January 5, 2023 10:09
@asteriscos asteriscos self-assigned this Jan 5, 2023
@asteriscos asteriscos linked an issue Jan 5, 2023 that may be closed by this pull request
3 tasks
@yenienserrano
Copy link
Member

Module With pinned agent Without agent
Security events 🟢 🟢
Integrity monitoring 🟢 🟢
Office 365 🟢
Amazon AWS 🟢 🟢
Google Cloud Platform 🟢
GitHub 🟢

Auditing and Policy Monitoring

Module With pinned agent Without agent
Policy monitoring 🟢 🟢
Security configuration assessment
System auditing 🟢 🟢
OpenSCAP
CIS-CAT

Threat Detection and Response

Module With pinned agent Without agent
Vulnerabilities
MITRE ATT&CK
VirusTotal 🟢 🟢
Osquery 🟢 🟢
Docker listener 🟢 🟢

Regulatory Compliance

Module With pinned agent Without agent
PCI DSS 🟢 🟢
NIST 800-53 🟢 🟢
GDPR 🟢 🟢
HIPAA 🟢 🟢
TSC 🟢 🟢

yenienserrano
yenienserrano previously approved these changes Jan 5, 2023
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2023

Code coverage (Jest) % values
Statements 8.74% ( 3231 / 36951 )
Branches 4.55% ( 1306 / 28679 )
Functions 7.62% ( 698 / 9160 )
Lines 8.8% ( 3116 / 35382 )

Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Module With pinned agent Without agent
Security events 🟢 🟢
Integrity monitoring 🟢 🟢
Office 365 🟢
Amazon AWS 🟢 🟢
Google Cloud Platform 🟢 🟢
GitHub 🟢

Auditing and Policy Monitoring

Module With pinned agent Without agent
Policy monitoring 🟢 🟢
Security configuration assessment
System auditing 🟢 🟢
OpenSCAP 🟢 🟢
CIS-CAT 🟢 🟢

Threat Detection and Response

Module With pinned agent Without agent
Vulnerabilities
MITRE ATT&CK
VirusTotal 🟢 🟢
Osquery 🟢 🟢
Docker listener 🟢 🟢

Regulatory Compliance

Module With pinned agent Without agent
PCI DSS 🟢 🟢
NIST 800-53 🟢 🟢
GDPR 🟢 🟢
HIPAA 🟢 🟢
TSC 🟢 🟢

@Desvelao Desvelao merged commit 1ba59fe into 4.4-2.4-wzd Jan 9, 2023
@Desvelao Desvelao deleted the backport-2.4-wzd/alerts-summary-and-last-alerts-missing-5044 branch January 9, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alerts summary and Last alerts data is missing in the reports of some modules
4 participants