Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix misspelling in NIST module #5107

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Fix misspelling in NIST module #5107

merged 1 commit into from
Jan 11, 2023

Conversation

AlexRuiz7
Copy link
Member

@AlexRuiz7 AlexRuiz7 commented Jan 11, 2023 •
edited
Loading

Description

Replace 'Requiments' by 'Requirements'

Issues Resolved

Closes #5099

Evidence

image

image

Test

Check the title has changed and is correct.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@AlexRuiz7
Fix mispeliing in NIST module
f7932b4 
Replace 'Requiments' by 'Requirements'
@AlexRuiz7 AlexRuiz7 self-assigned this Jan 11, 2023
@AlexRuiz7 AlexRuiz7 requested a review from a team as a code owner January 11, 2023 13:19
@AlexRuiz7 AlexRuiz7 linked an issue Jan 11, 2023 that may be closed by this pull request
Misspelling in the NIST report #5099
Closed
asteriscos
asteriscos approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️

@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 8.75% ( 3231 / 36901 )
Branches 4.55% ( 1306 / 28659 )
Functions 7.63% ( 698 / 9142 )
Lines 8.81% ( 3116 / 35335 )

Tostti
Tostti approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR:✔️

LGTM

@AlexRuiz7 AlexRuiz7 merged commit afd754a into 4.4-2.4-wzd Jan 11, 2023
@AlexRuiz7 AlexRuiz7 deleted the 5099-fix-nist-mispelling branch January 11, 2023 13:53
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
AlexRuiz7 added a commit that referenced this pull request Jan 11, 2023
@AlexRuiz7
Fix mispeliing in NIST module (#5107)
8bffa62 
Replace 'Requiments' by 'Requirements'

(cherry picked from commit afd754a)
@AlexRuiz7 AlexRuiz7 mentioned this pull request Jan 11, 2023
Merged
AlexRuiz7 added a commit that referenced this pull request Jan 11, 2023
@AlexRuiz7
Fix mispeliing in NIST module (#5107)
56a967a 
Replace 'Requiments' by 'Requirements'

(cherry picked from commit afd754a)
@AlexRuiz7 AlexRuiz7 mentioned this pull request Jan 11, 2023
Merged
@AlexRuiz7 AlexRuiz7 changed the title Fix mispeliing in NIST module Fix misspelling in NIST module Jan 11, 2023
AlexRuiz7 added a commit that referenced this pull request Jan 11, 2023
@AlexRuiz7
[Backport 4.4-7.10] Fix mispeliing in NIST module (#5109)
e5eded4 
* Fix mispeliing in NIST module (#5107)

Replace 'Requiments' by 'Requirements'

(cherry picked from commit afd754a)

* Update CHANGELOG.md
AlexRuiz7 added a commit that referenced this pull request Jan 11, 2023
@AlexRuiz7
[Backport 4.4-7.16] Fix mispeliing in NIST module (#5108)
6d89d2e 
* Fix mispeliing in NIST module (#5107)

Replace 'Requiments' by 'Requirements'

(cherry picked from commit afd754a)

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tostti Tostti Tostti approved these changes

@asteriscos asteriscos asteriscos approved these changes

Assignees

@AlexRuiz7 AlexRuiz7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Misspelling in the NIST report
3 participants
@AlexRuiz7 @asteriscos @Tostti