-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Agents table action buttons style fix #5177
Agents table action buttons style fix #5177
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TEST
Chrome | Firefox | Edge | Safari |
---|---|---|---|
🟢 | 🟢 | 🟢 | ⚫ |
Evidence
🟢 Chrome
Chrome.mp4
🟢 Firefox
Firefox.mp4
🟢 Edge
Edge.mp4
TEST:✔️
CR:✔️
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing evidence
Chrome | Firefox | Edge | Safari |
---|---|---|---|
🟢 | 🟢 | ⚫ | ⚫ |
Evidence
🟢 Chrome
Kazam_screencast_00009.mp4
🟢 Firefox
Kazam_screencast_00010.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
* Remove flex class * Add changelog * Fix table action buttons flex style (cherry picked from commit 018a225)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-7.10 4.4-7.10
# Navigate to the new working tree
cd .worktrees/backport-4.4-7.10
# Create a new branch
git switch --create backport-5177-to-4.4-7.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 018a22501c79c118a6820018176615ffde943b19
# Push it to GitHub
git push --set-upstream origin backport-5177-to-4.4-7.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-7.10 Then, create a pull request where the |
* Remove flex class * Add changelog * Fix table action buttons flex style (cherry picked from commit 018a225)
Description
Hi team,
This PR removes the flex-wrap style from the action buttons of the Agents table. This is to avoid the buttons wrapping unnecessarily in firefox.
Issues Resolved
Related to #5141
Evidence
Test
Check List
yarn test:jest