Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agents table action buttons style fix #5177

Merged
merged 3 commits into from
Jan 27, 2023

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented Jan 27, 2023

Description

Hi team,

This PR removes the flex-wrap style from the action buttons of the Agents table. This is to avoid the buttons wrapping unnecessarily in firefox.

Issues Resolved

Related to #5141

Evidence

Peek 2023-01-27 17-48

Test

  • Go to Agents Overview
  • Change the screen size to see the buttons horizontally and vertically
Chrome Firefox Safari

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos self-assigned this Jan 27, 2023
@asteriscos asteriscos requested a review from a team as a code owner January 27, 2023 15:52
@Machi3mfl Machi3mfl self-requested a review January 27, 2023 16:00
@Machi3mfl Machi3mfl linked an issue Jan 27, 2023 that may be closed by this pull request
Tostti
Tostti previously approved these changes Jan 27, 2023
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TEST

Chrome Firefox Edge Safari
🟢 🟢 🟢

Evidence

🟢 Chrome
Chrome.mp4
🟢 Firefox
Firefox.mp4
🟢 Edge
Edge.mp4

TEST:✔️
CR:✔️

LGTM

Machi3mfl
Machi3mfl previously approved these changes Jan 27, 2023
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing evidence

Chrome Firefox Edge Safari
🟢 🟢

Evidence

🟢 Chrome
Kazam_screencast_00009.mp4
🟢 Firefox
Kazam_screencast_00010.mp4

@asteriscos asteriscos dismissed stale reviews from Machi3mfl and Tostti via 79f9e1d January 27, 2023 16:23
Tostti
Tostti previously approved these changes Jan 27, 2023
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing evidence

Chrome Firefox Edge Safari
🟢 🟢 🟢

Evidence

🟢 Chrome image
🟢 Firefox image
🟢 Safari image

@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 8.77% ( 3239 / 36923 )
Branches 4.5% ( 1291 / 28667 )
Functions 7.63% ( 698 / 9147 )
Lines 8.83% ( 3124 / 35358 )

@asteriscos asteriscos merged commit 018a225 into 4.4-2.4-wzd Jan 27, 2023
@asteriscos asteriscos deleted the fix/agents-table-action-buttons-style branch January 27, 2023 16:51
github-actions bot pushed a commit that referenced this pull request Jan 27, 2023
* Remove flex class

* Add changelog

* Fix table action buttons flex style

(cherry picked from commit 018a225)
@github-actions
Copy link
Contributor

The backport to 4.4-7.10 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-7.10 4.4-7.10
# Navigate to the new working tree
cd .worktrees/backport-4.4-7.10
# Create a new branch
git switch --create backport-5177-to-4.4-7.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 018a22501c79c118a6820018176615ffde943b19
# Push it to GitHub
git push --set-upstream origin backport-5177-to-4.4-7.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-7.10

Then, create a pull request where the base branch is 4.4-7.10 and the compare/head branch is backport-5177-to-4.4-7.10.

asteriscos added a commit that referenced this pull request Jan 27, 2023
* Remove flex class

* Add changelog

* Fix table action buttons flex style

(cherry picked from commit 018a225)
asteriscos added a commit that referenced this pull request Jan 27, 2023
Agents table action buttons style fix (#5177)

* Remove flex class

* Add changelog

* Fix table action buttons flex style

(cherry picked from commit 018a225)

Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com>
asteriscos added a commit that referenced this pull request Jan 27, 2023
Agents table action buttons style fix (#5177)

* Remove flex class

* Add changelog

* Fix table action buttons flex style

(cherry picked from commit 018a225)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable sync information in agent table by default
4 participants