Fix a crash in the vulnerability details flyout #5200

Desvelao · 2023-02-07T16:04:16Z

Description

This pull request fixes a UI crash when opening the details of a vulnerability that has no the external_references field.

The changes ensure the field is defined and is an array.

If there is data related to external references, then a - will be displayed

Issues Resolved

#5199

Evidence

Test

UI

Test
See the References of a vulnerability that has one or more references, it should display the accordion with the references.
See the References of a vulnerability that has no references, it should display a `-`.
See the References of a vulnerability that the references are not defined, it should display a `-`.

crash-vulnerability-data-no-external-references.md

Imposter patch that adds some vulnerability data without the external_references field (called Custom and Custom2).
pr-5199-imposter.txt

Check List

All tests pass
- yarn test:jest
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

…es` field could not be defined in the API response Ensure the `external_references` field is defined with the expected data structure as an array mapping each `affected_items` of the API response.

github-actions · 2023-02-07T16:18:46Z

Code coverage (Jest)	%	values
Statements	8.77%	( 3239 / 36924 )
Branches	4.5%	( 1291 / 28671 )
Functions	7.63%	( 698 / 9148 )
Lines	8.83%	( 3124 / 35359 )

Tostti

Test

Test
See the References of a vulnerability that has one or more references, it should display the accordion with the references.	🟢
See the References of a vulnerability that has no references, it should display a `-`.	🟢
See the References of a vulnerability that the references are not defined, it should display a `-`.	🟢

Evidence

See the References of a vulnerability that has one or more references, it should display the accordion with the references.
See the References of a vulnerability that has no references, it should display a -.
See the References of a vulnerability that the references are not defined, it should display a -.

TEST:✔️
CR:✔️

LGTM

yenienserrano · 2023-02-09T09:58:56Z

Wazuh dashboard

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test	Chrome	Firefox	Safari
See the References of a vulnerability that has one or more references, it should display the accordion with the references.	🟢	🟢	⚫
See the References of a vulnerability that has no references, it should display a `-`.	🟢	🟢	⚫
See the References of a vulnerability that the references are not defined, it should display a `-`.	🟢	🟢	⚫

Details

🟢 See the References of a vulnerability that has one or more references, it should display the accordion with the references.

Chrome - 🟢

Firefox - 🟢

Safari - ⚫

🟢 See the References of a vulnerability that has no references, it should display a `-`.

Chrome - 🟢

Firefox - 🟢

Safari - ⚫

🟢 See the References of a vulnerability that the references are not defined, it should display a `-`.

Chrome - 🟢

Firefox - 🟢

Safari - ⚫

github-actions · 2023-02-10T11:25:44Z

The backport to 4.4-7.16 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-7.16 4.4-7.16
# Navigate to the new working tree
cd .worktrees/backport-4.4-7.16
# Create a new branch
git switch --create backport-5200-to-4.4-7.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 08fc532046f0148840d583383117a9d0dedf2bf6
# Push it to GitHub
git push --set-upstream origin backport-5200-to-4.4-7.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-7.16

Then, create a pull request where the base branch is 4.4-7.16 and the compare/head branch is backport-5200-to-4.4-7.16.

github-actions · 2023-02-10T11:25:45Z

The backport to 4.4-7.10 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-7.10 4.4-7.10
# Navigate to the new working tree
cd .worktrees/backport-4.4-7.10
# Create a new branch
git switch --create backport-5200-to-4.4-7.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 08fc532046f0148840d583383117a9d0dedf2bf6
# Push it to GitHub
git push --set-upstream origin backport-5200-to-4.4-7.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-7.10

Then, create a pull request where the base branch is 4.4-7.10 and the compare/head branch is backport-5200-to-4.4-7.10.

* fix(vulnerability): fix a crash caused because the `external_references` field could not be defined in the API response Ensure the `external_references` field is defined with the expected data structure as an array mapping each `affected_items` of the API response. * changelog: add pull request entry (cherry picked from commit 08fc532)

…5205) Fix a crash in the vulnerability details flyout (#5200) * fix(vulnerability): fix a crash caused because the `external_references` field could not be defined in the API response Ensure the `external_references` field is defined with the expected data structure as an array mapping each `affected_items` of the API response. * changelog: add pull request entry (cherry picked from commit 08fc532)

…5204) Fix a crash in the vulnerability details flyout (#5200) * fix(vulnerability): fix a crash caused because the `external_references` field could not be defined in the API response Ensure the `external_references` field is defined with the expected data structure as an array mapping each `affected_items` of the API response. * changelog: add pull request entry (cherry picked from commit 08fc532)

* fix(vulnerability): fix a crash caused because the `external_references` field could not be defined in the API response Ensure the `external_references` field is defined with the expected data structure as an array mapping each `affected_items` of the API response. * changelog: add pull request entry

fix(vulnerability): fix a crash caused because the `external_referenc…

86693d8

…es` field could not be defined in the API response Ensure the `external_references` field is defined with the expected data structure as an array mapping each `affected_items` of the API response.

Desvelao requested a review from a team as a code owner February 7, 2023 16:04

Desvelao self-assigned this Feb 7, 2023

Desvelao linked an issue Feb 7, 2023 that may be closed by this pull request

Crash in vulnerabilities module due to references missing field #5199

Closed

changelog: add pull request entry

23f671e

Desvelao added backport 4.4-7.16 labels Feb 7, 2023

Desvelao mentioned this pull request Feb 7, 2023

Crash in vulnerabilities module due to references missing field #5199

Closed

Machi3mfl self-requested a review February 8, 2023 13:40

Tostti approved these changes Feb 8, 2023

View reviewed changes

yenienserrano approved these changes Feb 9, 2023

View reviewed changes

Desvelao merged commit 08fc532 into 4.4-2.4-wzd Feb 10, 2023

Desvelao deleted the fix/5199-crash-vulnerability-data-external-references-field branch February 10, 2023 11:25

This was referenced Feb 10, 2023

[Backport 4.4-7.16] Fix a crash in the vulnerability details flyout #5204

Merged

[Backport 4.4-7.10] Fix a crash in the vulnerability details flyout #5205

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix a crash in the vulnerability details flyout #5200

Fix a crash in the vulnerability details flyout #5200

Desvelao commented Feb 7, 2023 •

edited

Loading

github-actions bot commented Feb 7, 2023

Tostti left a comment

yenienserrano commented Feb 9, 2023 •

edited

Loading

github-actions bot commented Feb 10, 2023

github-actions bot commented Feb 10, 2023

Fix a crash in the vulnerability details flyout #5200

Fix a crash in the vulnerability details flyout #5200

Conversation

Desvelao commented Feb 7, 2023 • edited Loading

Description

Issues Resolved

Evidence

Test

UI

Check List

github-actions bot commented Feb 7, 2023

Tostti left a comment

Choose a reason for hiding this comment

Test

Evidence

yenienserrano commented Feb 9, 2023 • edited Loading

Wazuh dashboard

UI

github-actions bot commented Feb 10, 2023

github-actions bot commented Feb 10, 2023

Desvelao commented Feb 7, 2023 •

edited

Loading

yenienserrano commented Feb 9, 2023 •

edited

Loading