Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Deploy Agent wrong use of connection secure property #5285

Merged

Conversation

Machi3mfl
Copy link
Member

@Machi3mfl Machi3mfl commented Mar 13, 2023

Description

This PR, fixes an undefined property use.
Closes #5283

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Machi3mfl Machi3mfl requested a review from a team as a code owner March 13, 2023 14:17
@Machi3mfl Machi3mfl changed the title Changed wrong use connection secure property Fix Deploy Agent wrong use of connection secure property Mar 13, 2023
@Machi3mfl
Copy link
Member Author

Machi3mfl commented Mar 13, 2023

Test Cases

  1. Check the following messages when the connection is secure.

image

Messages:

  • Might require some extra installation
  • After installing the agent, you need to enroll it in the Wazuh server. Check the Wazuh agent enrollment

In SO:

  • Solaris 10 and 11
Kazam_screencast_00019.mp4
  • HP - 11.31
    image

  • Alpine 3.12.12
    image

Messages:

  • Might require some extra installation

In SO

  • Aix - 6.1 TL9
    image
  • All Debian's SO
Kazam_screencast_00018.mp4

@Machi3mfl Machi3mfl changed the title Fix Deploy Agent wrong use of connection secure property Fixed Deploy Agent wrong use of connection secure property Mar 13, 2023
yenienserrano
yenienserrano previously approved these changes Mar 13, 2023
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

Solaris:
image

image

HP-UX:
image

Alpine:
image

@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 8.77% ( 3239 / 36924 )
Branches 4.5% ( 1291 / 28671 )
Functions 7.63% ( 698 / 9148 )
Lines 8.83% ( 3124 / 35359 )

@Machi3mfl Machi3mfl merged commit 7140b80 into 4.4-2.4-wzd Mar 13, 2023
@Machi3mfl Machi3mfl deleted the fix/5283-deploy-new-agent-connection-secure-conditions branch March 13, 2023 17:20
@github-actions
Copy link
Contributor

The backport to 4.4-7.16 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-7.16 4.4-7.16
# Navigate to the new working tree
cd .worktrees/backport-4.4-7.16
# Create a new branch
git switch --create backport-5285-to-4.4-7.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7140b80b6433a858509c0ece826dd171a0f3e3d6
# Push it to GitHub
git push --set-upstream origin backport-5285-to-4.4-7.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-7.16

Then, create a pull request where the base branch is 4.4-7.16 and the compare/head branch is backport-5285-to-4.4-7.16.

@github-actions
Copy link
Contributor

The backport to 4.4-7.10 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-7.10 4.4-7.10
# Navigate to the new working tree
cd .worktrees/backport-4.4-7.10
# Create a new branch
git switch --create backport-5285-to-4.4-7.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7140b80b6433a858509c0ece826dd171a0f3e3d6
# Push it to GitHub
git push --set-upstream origin backport-5285-to-4.4-7.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-7.10

Then, create a pull request where the base branch is 4.4-7.10 and the compare/head branch is backport-5285-to-4.4-7.10.

Machi3mfl added a commit that referenced this pull request Mar 13, 2023
* Changed wrong use connection secure property

* Updated CHANGELOG

(cherry picked from commit 7140b80)
Machi3mfl added a commit that referenced this pull request Mar 13, 2023
* Changed wrong use connection secure property

* Updated CHANGELOG

(cherry picked from commit 7140b80)
AlexRuiz7 pushed a commit that referenced this pull request Mar 17, 2023
* Changed wrong use connection secure property

* Updated CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Deploy new agent doesn't display the extra requirements in the install and enroll the agent
2 participants