Wrong condition when generating the RPM Wazuh indexer package with an existent base file

[rauldpm]

Description

During the development of the issue #2402 it has been found that when creating the RPM package without wanting to create the base file, the Wazuh version is not being correctly obtained

╰─➤  bash build_package.sh -b no       
+ build
+ build_name=
+ file_path=
+ '[' x86_64 = x86_64 ']'
+ architecture=x86_64
+ build_name=rpm_indexer_builder_x86
+ file_path=/wazuh-packages/tags/stack/indexer/rpm/docker/x86_64
+ build_rpm rpm_indexer_builder_x86 /wazuh-packages/tags/stack/indexer/rpm/docker/x86_64
+ container_name=rpm_indexer_builder_x86
+ dockerfile_path=/wazuh-packages/tags/stack/indexer/rpm/docker/x86_64
+ cp /wazuh-packages/tags/stack/indexer/rpm/builder.sh /wazuh-packages/tags/stack/indexer/rpm/docker/x86_64
+ '[' no == yes ']'
+ '[' '' ']'
++ curl -sL https://raw.githubusercontent.com/wazuh/wazuh-packages//VERSION
++ cat
+ version='400: Invalid request'
+ basefile='/wazuh-packages/tags/stack/indexer/rpm/output/wazuh-indexer-base-400: Invalid request-1-linux-x64.tar.xz'
+ test -f '/wazuh-packages/tags/stack/indexer/rpm/output/wazuh-indexer-base-400: Invalid request-1-linux-x64.tar.xz'
+ echo 'Did not find expected Wazuh indexer base file: /wazuh-packages/tags/stack/indexer/rpm/output/wazuh-indexer-base-400: Invalid request-1-linux-x64.tar.xz in output path. Exiting...'
Did not find expected Wazuh indexer base file: /wazuh-packages/tags/stack/indexer/rpm/output/wazuh-indexer-base-400: Invalid request-1-linux-x64.tar.xz in output path. Exiting...
+ exit 1

This is due to an erroneous negation in the following condition

wazuh-packages/stack/indexer/rpm/build_package.sh

Line 54 in c9d5a07

if ! [ "${reference}" ];then

Tasks

• Remove the negation from the condition

Validation

• The base file is found by using the -b no parameter

[rauldpm]

Update report

• Removing the negation the base is looked for using the correct version

╰─➤  bash build_package.sh -b no          
+ build
+ build_name=
+ file_path=
+ '[' x86_64 = x86_64 ']'
+ architecture=x86_64
+ build_name=rpm_indexer_builder_x86
+ file_path=/wazuh-packages/tags/stack/indexer/rpm/docker/x86_64
+ build_rpm rpm_indexer_builder_x86 /wazuh-packages/tags/stack/indexer/rpm/docker/x86_64
+ container_name=rpm_indexer_builder_x86
+ dockerfile_path=/wazuh-packages/tags/stack/indexer/rpm/docker/x86_64
+ cp /wazuh-packages/tags/stack/indexer/rpm/builder.sh /wazuh-packages/tags/stack/indexer/rpm/docker/x86_64
+ '[' no == yes ']'
+ '[' '' ']'
++ cat /wazuh-packages/tags/stack/indexer/rpm/../../../VERSION
+ version=4.7.0
+ basefile=/wazuh-packages/tags/stack/indexer/rpm/output/wazuh-indexer-base-4.7.0-1-linux-x64.tar.xz
+ test -f /wazuh-packages/tags/stack/indexer/rpm/output/wazuh-indexer-base-4.7.0-1-linux-x64.tar.xz
+ echo 'Did not find expected Wazuh indexer base file: /wazuh-packages/tags/stack/indexer/rpm/output/wazuh-indexer-base-4.7.0-1-linux-x64.tar.xz in output path. Exiting...'
Did not find expected Wazuh indexer base file: /wazuh-packages/tags/stack/indexer/rpm/output/wazuh-indexer-base-4.7.0-1-linux-x64.tar.xz in output path. Exiting...
+ exit 1

[davidjiglesias]

LGTM!