Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed system tests due to KeyError #4941

Closed
juliamagan opened this issue Feb 8, 2024 · 3 comments · Fixed by #4958
Closed

Failed system tests due to KeyError #4941

juliamagan opened this issue Feb 8, 2024 · 3 comments · Fixed by #4958
Assignees
@Rebits
Labels
level/task Task issue type/bug

Comments

@juliamagan
Copy link
Member

Description

During the release of the system tests for 4.8.0 Beta 1, carried out in wazuh/wazuh#21787, it was found that most of the tests failed due to a KeyError. You can see the attached reports here.

These tests are dependent, and some may not have failed explicitly because of the KeyError but may be affected by a previous KeyError.

We should fix this error and check that all system tests pass as expected.
@juliamagan juliamagan mentioned this issue Feb 8, 2024
Closed
1 task
@wazuhci wazuhci moved this to Triage in Release 4.8.0 Feb 8, 2024
@wazuhci wazuhci moved this from Backlog to In progress in Release 4.8.0 Feb 12, 2024
@Rebits
Copy link
Member

Rebits commented Feb 12, 2024

KeyError was produced by bug reported here #4936
Fix seems to be solved here

However, it seems it is failing in get_host_variables method. Currently testing fix

@Rebits Rebits linked a pull request Feb 13, 2024 that will close this issue
Fix get_host_variables for system tests #4958
Merged
@wazuhci wazuhci moved this from In progress to Pending review in Release 4.8.0 Feb 13, 2024
@pro-akim
Copy link
Member

Review Notes

LGTM

Tested:
agentless.zip

@wazuhci wazuhci moved this from Pending review to Pending final review in Release 4.8.0 Feb 13, 2024
@davidjiglesias
Copy link
Member

LGTM

@wazuhci wazuhci moved this from Pending final review to Done in Release 4.8.0 Feb 14, 2024
@Deblintrake09 Deblintrake09 mentioned this issue Feb 26, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rebits Rebits

Labels
level/task Task issue type/bug
Projects
No open projects
Release 4.8.0
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix get_host_variables for system tests wazuh/wazuh-qa
4 participants
@Rebits @davidjiglesias @juliamagan @pro-akim