Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new compliance groups HIPAA and NIST 800 53 #705

Closed
adri9valle opened this issue May 15, 2019 · 8 comments
Closed

Support new compliance groups HIPAA and NIST 800 53 #705

adri9valle opened this issue May 15, 2019 · 8 comments
Assignees
Labels
type/enhancement Enhancement issue

Comments

@adri9valle
Copy link
Contributor

This issue is related to:

App must consider new groups that are being added to the ruleset:

  • hipaa
  • nist-800-53
@jesusgn90
Copy link

Proposal

  • Two new dashboards for both HIPAA and NIST-800-53 as well, under Regulatory Compliance
    • Overview, Agents

@pablotr9 pablotr9 self-assigned this May 29, 2019
@pablotr9
Copy link
Contributor

Working on this branch: https://github.com/wazuh/wazuh-splunk/tree/hipaa-nist

  • HIPAA and NIST 800-53 have been added as extensions:
    image

  • Both extensions have been added to Overview -> Regulatory Compliance:
    image

  • They have also been added to Agents -> Regulatory Compliance:
    image
    Currently HIPAA and NIST 800-53 dashboards are empty until Wazuh API adds calls for these new extensions.

  • We can now filter by these two new extensions at Management -> Rules search filter bar:
    image

@pablotr9
Copy link
Contributor

UPDATE
HIPAA and NIST-800-53 dashboards have been updated and tested with Wazuh 3.10 for both Overview and Agents sections.
-Descriptions for NIST-800-53 requirements have been added.

An example of Overview -> NIST 800-53 Dashboard
Screenshot from 2019-05-31 13-28-24

Currently working on adding HIPAA requirements description.

@pablotr9
Copy link
Contributor

pablotr9 commented Jun 3, 2019

Update
It has been added new description for HIPAA requirements and NIST 800-53 requirements. 675d073
There was an error with Nist-800-53 visualizations due to the use of underscores in its name, it has been fixed here: 13f70f8
Now we can filter our ruleset by HIPAA and NIST 800-53 requirements:8fa46b0
image

@jesusgn90
Copy link

This visualization is wrong:

image

Please, change its look & feel, you can use wazuh/wazuh-dashboard-plugins#1448 (comment) as reference.

The requirements slider is a bit rough:

image

On the other hand, the issue doesn't show the full dashboard, add screenshot once finished.

Thanks

@pablotr9
Copy link
Contributor

pablotr9 commented Jun 5, 2019

UPDATE
Those requested improvements to HIPAA and NIST 800-53 dashboards have been added here: d6b3e27
PCI DSS and GDPR dashboards have also been updated in order to maintain the proposed style.

Overview dashboards:

  • PCI DSS
    overview-pci
  • GDPR
    gdpr-overview
  • HIPAA
    hipaa-overview
  • NIST 800-53
    nist-overview

AGENTS dashboards:

  • PCI DSS
    pci-overview
  • GDPR
    gdpr-agents
  • HIPAA
    hipa-agents
  • NIST 800-53
    nist-agents

@jesusgn90
Copy link

This visualization is still wrong and it exists in more than one dashboard. This should be an aggregation and the right legend should show requirement names instead of "Count"

image

A valid example:

image

This is not how we show the timestamp field:

image

Please use the grid properly:

image

Be consistent:

image

@pablotr9
Copy link
Contributor

pablotr9 commented Jun 6, 2019

UPDATE
Grid are now used properly, text descriptions are consistent and the _time has been replaced 7e05216.
I have encountered some problems renaming _time, the easiest way to do that was by simply renaming _time for a human-readable format as follows:
(search query) | rename _time as "Time span" Screenshot from 2019-06-06 10-37-26

Renaming _time forced Splunk to format _time value to milliseconds but we need a human-readable format for this value as well, this can be solved by formatting it again:
(search query)| rename _time as Time | convert ctime(Time)
Screenshot from 2019-06-06 10-49-54
Once again, this date transformation (from milliseconds to dd/mm/yyyy HH:MM:SS) changed the user selected time range.
I finally achieved this by modifying all our chart classes so they now have one new optional param:
{customAxisTitleX : "Time span"}
This new param can be set to all our chart visualizations so we can set a custom axis X title without modifying any of the visualization data or time range as the next screenshot shows:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Enhancement issue
Projects
None yet
Development

No branches or pull requests

3 participants