Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support netstandard 2.0 #149

Closed
ElderJames opened this issue Jul 16, 2024 · 4 comments · Fixed by #150 or #152
Closed

support netstandard 2.0 #149

ElderJames opened this issue Jul 16, 2024 · 4 comments · Fixed by #150 or #152
Assignees
Labels
enhancement New feature or request

Comments

@ElderJames
Copy link
Contributor

I want to use markdig and this extensions in Source Generators.

@ElderJames ElderJames mentioned this issue Jul 16, 2024
13 tasks
@wbaldoumas wbaldoumas self-assigned this Jul 16, 2024
@wbaldoumas wbaldoumas added the enhancement New feature or request label Jul 16, 2024
@wbaldoumas
Copy link
Owner

Thanks for opening up this issue, @ElderJames.

Unfortunately CsharpToColouredHTML, which this library depends on, does not support .NET Standard 2.0. Support for .NET Standard 2.0 will need to be added there first before making these updates to Markdown.ColorCode.

@wbaldoumas
Copy link
Owner

@ElderJames unfortunately the pull request that was just merged won't allow for the Markdown.ColorCode.CSharpToColoredHtml package to be built.

Although you only targeted Markdown.ColorCode with your .NET Standard 2.0 TFM update, Markdown.ColorCode.CSharpToColoredHtml depends on the main package and will not build with that update in place. For now, I'm reopening this issue and reverting your change.

Please open an issue in the CsharpToColouredHTML repository regarding .NET Standard 2.0 support so we can get this change pushed through for both Markdown.ColorCode and Markdown.ColorCode.CSharpToColoredHtml if you still need it.

@ElderJames
Copy link
Contributor Author

What's the issue with Markdown.ColorCode.CSharpToColoredHtml? It build successfully on my locale PC.

@wbaldoumas wbaldoumas mentioned this issue Jul 17, 2024
13 tasks
@wbaldoumas
Copy link
Owner

What's the issue with Markdown.ColorCode.CSharpToColoredHtml? It build successfully on my locale PC.

You're right. I opened #152 to reintroduce your changes but also bump the version number to trigger a release. Thanks for the patience on this one - totally my bad regarding the build issue. 🤦‍♀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants