Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

summary message should not show ‘no changes’ #23

Closed
wbolster opened this issue Feb 27, 2018 · 1 comment
Closed

summary message should not show ‘no changes’ #23

wbolster opened this issue Feb 27, 2018 · 1 comment

Comments

@wbolster
Copy link
Owner

when direnv-mode is enabled, and direnv-always-show-summary is on, the summary message shows ‘no changes’ when changing between files within the same (direnv managed) project, when those files reside in different directories, e.g. implementation and tests.

it would be nice if the ‘no changes’ message was not shown.

@wbolster
Copy link
Owner Author

wbolster commented Feb 27, 2018

smarter default behaviour of summary messages on environment change

this changes the default behaviour to show a summary of environment
changes in the minibuffer, but only if there actually are changes.

for interactive calls, a summary message is always shown, as before.
explicit user interaction always leads to direct user feedback.

on the other hand, when using direnv-mode, and for non-interactive
calls (e.g. from hooks), the logic to decide whether to show a summary
message is now smarter than before. as a result the
direnv-always-show-summary variable is now enabled by default.

in practice, the new behaviour will avoid automatic useless minibuffer
messages (‘direnv: no changes’) all the time when switching between
files in different directories, but within the same direnv controlled
project directory, which is what happened before this change.

closes #23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant