Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken installation of package dependencies. #1

Merged
merged 2 commits into from
May 21, 2012
Merged

Fix broken installation of package dependencies. #1

merged 2 commits into from
May 21, 2012

Conversation

todddeluca
Copy link

A common way to break project installation is to import the package in
setup.py in order to get access to mypackage.version. However if
mypackage depends on a different uninstalled package, the import will
fail, causing setup.py to fail before it has a chance to install the
dependency.

The fix is to find some other DRY way to get at version.

For more details see:

Todd DeLuca added 2 commits May 21, 2012 15:12
A common way to break project installation is to import the package in
setup.py in order to get access to mypackage.__version__.  However if
mypackage depends on a different uninstalled package, the import will
fail, causing setup.py to fail before it has a chance to install the
dependency.

The fix is to find some other DRY way to get at __version__.

For more details see:

- http://stackoverflow.com/questions/458550/
- http://stackoverflow.com/questions/2058802/
@wbolster wbolster merged commit 5366974 into python-happybase:master May 21, 2012
@wbolster
Copy link
Member

Thanks, I've merged your fix and also updated the installation guide in the docs.

@csabaszilveszter csabaszilveszter mentioned this pull request Feb 4, 2016
3 tasks
@myloginid myloginid mentioned this pull request Aug 30, 2016
gabrii pushed a commit to gabrii/happybase that referenced this pull request Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants