Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Log Warning on Shutdown #18

Merged
merged 1 commit into from
Feb 5, 2013
Merged

Fix Log Warning on Shutdown #18

merged 1 commit into from
Feb 5, 2013

Conversation

defcube
Copy link
Contributor

@defcube defcube commented Feb 3, 2013

Upon shutdown, this error was displayed:
Exception AttributeError: "'NoneType' object has no attribute 'debug'" in <bound method Connection.del of <happybase.api.Connection object at 0x106878250>> ignored

@defcube
Fix Log Warning on Shutdown
af97c3f 
Upon shutdown, this error was displayed:
Exception AttributeError: "'NoneType' object has no attribute 'debug'" in <bound method Connection.__del__ of <happybase.api.Connection object at 0x106878250>> ignored
wbolster added a commit that referenced this pull request Feb 5, 2013
@wbolster
Avoid warnings on shutdown if the logger is gone
881ca6a 
Closes issue #18.
@wbolster wbolster merged commit af97c3f into python-happybase:master Feb 5, 2013
@wbolster
Copy link
Member

wbolster commented Feb 5, 2013

To answer my own questions (well, try to answer after some quick research):

  • self.transport is not a module variable, so it will not be gone at the time __del__() is called
  • the destructor seems needed; at least the telnetlib module from the standard library does something similar with its socket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@defcube @wbolster