-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Thrift v0.9.0 and added a README.TXT file. #27
Conversation
Wow, I was just looking into compiling Thrift when I saw this request. Thanks. :) Are these the unchanged files generated by Thrift? |
Follow-up question: which HBase version does the |
Yes it's unchanged :) I did use the py:new_style option so they actually use new classes. I'll version the .thrift version too to make it more clear. :) |
I'm not sure about the symlink approach. It might confuse packaging tools. I'd rather have an explicit README stating the exact versions. |
I left the Hbase.thrift file alone since it appears that the latest 0.98.4 has some additional IDL definitions. Updated the README.TXT file inside hbase/. |
```bash | ||
thrift --gen py:new_style Hbase.thrift | ||
``` | ||
Thrift version used: 0.9.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure which HBase version is being used. It looks like 0.98.4 at http://apache.petsads.us/hbase/stable/ has a different IDL, but not ready to upgrade yet.. :)
I'm resolving this issue now. Thanks for your contribution! |
Thanks for your fast response and support of this library! On Tue, Jun 4, 2013 at 2:05 PM, Wouter Bolsterlee
|
Use a symlink for the hbase/ directory to help denote the version being used.