-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
table.scan() with filter set will always fail in happybase >= 0.7 #54
Comments
Would a simple removal of the batch size argument in case a filter argument was supplied introduce other issues? |
Allow None as a valid value for the batch_size argument to Table.scan(), since HBase does not support specifying a batch size when some scanner filters are used. Fixes issue #54.
@ruhe Please test these changes and let me know whether this is a good enough fix? Thanks. |
@ruhe I'm not completely sure how the |
@wbolster thanks a lot for fixing it so fast! i'll definitely test this fix, stay tuned :) |
It's a bit more complicated; see issue #56. |
Project: openstack/requirements 051bd0cca12c57f2fd016f56db2be724c30499f9 null Fix happybase version Since version 0.7 happybase contains a bug python-happybase/happybase#54 It makes impossible HBase table scanning with filters. Version 0.6 works ok in this scenario. Change-Id: I33bad6447f6bc1241f3168a3df14e6f5bf028f5b
Project: openstack/requirements 051bd0cca12c57f2fd016f56db2be724c30499f9 null Fix happybase version Since version 0.7 happybase contains a bug python-happybase/happybase#54 It makes impossible HBase table scanning with filters. Version 0.6 works ok in this scenario. Change-Id: I33bad6447f6bc1241f3168a3df14e6f5bf028f5b
Since version 0.7 happybase contains a bug python-happybase/happybase#54 It makes impossible HBase table scanning with filters. Version 0.6 works ok in this scenario. Change-Id: I33bad6447f6bc1241f3168a3df14e6f5bf028f5b
Should be fixed in 0.8 (just released). |
Hi. I appreciate your works but it won't fixed. I upgraded to v.8 and below is my code which working with Hbase0.96
And below is the result in terminal:
And thrit log:
Thrift said 'users' table not found but it was there in the list of tables |
I downgraded to Hbase0.94. V8 worked well. |
I doubt that that is the same issue as the incorrect scan arguments, since for that I have a test that fails before and passes after my most recent fixes. Are you sure your database is valid? Can you access it using the HBase shell, for instance? |
sorry, that's my fault. I created all tables by using combat 0.94 in connection method ( I forgot update to 0.96 ). Now it worked. |
@bachvtuan ok, glad to hear that it works. |
Since version 0.7 happybase contains a bug python-happybase/happybase#54 It blocks efficient HBase table scanning. Version 0.6 works ok in this scenario. Change-Id: I33bad6447f6bc1241f3168a3df14e6f5bf028f5b
Since version 0.7 happybase contains a bug python-happybase/happybase#54 It makes impossible HBase table scanning with filters. Version 0.6 works ok in this scenario. Change-Id: I33bad6447f6bc1241f3168a3df14e6f5bf028f5b
Patch Set 1: @sean, there is a bug in 0.7 python-happybase/happybase#54 . It make impossible to work with hbase Patch-set: 1
Description:
batchSize should not be set on scans with filter.
happybase v0.7 introduced new argument batchSize for TScan in method happybase.table.scan(). When used with filter this parameter will cause all scan operations to fail.
happybase always passes batch_size to TScan, even if there is filter_string present.
there is no way to set batch_size to None since method scan() validates batch_size value:
https://github.com/wbolster/happybase/blob/0.7/happybase/table.py#L259
See corresponding HBase code:
http://grepcode.com/file/repo1.maven.org/maven2/org.apache.hbase/hbase/0.94.9/org/apache/hadoop/hbase/client/Scan.java?av=f#311
Steps to reproduce:
The text was updated successfully, but these errors were encountered: