Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup the batch size and caching scanner flags #56

Closed
wbolster opened this issue Jan 26, 2014 · 1 comment
Closed

Cleanup the batch size and caching scanner flags #56

wbolster opened this issue Jan 26, 2014 · 1 comment

Comments

@wbolster
Copy link
Member

The current implementation mixes up these options affecting scanner behaviour and performance:

  • batch size for fetching frows, used between the Python process and the Thrift server
  • batch size passed as a scanner option, used between the Thrift server and region servers
  • caching size passed as a scanner option, also used between the Thrift server and region servers
@wbolster wbolster mentioned this issue Feb 1, 2014
Closed
wbolster added a commit that referenced this issue Feb 25, 2014
@wbolster
Revert "Allow batch_size=None in Table.scan() to avoid filter incompa…
da109ab 
…tibilities"

This reverts commit 8481d31, since it
is not a correct fix. See issue #56.
wbolster added a commit that referenced this issue Feb 25, 2014
@wbolster
No longer confuse batching/caching; add Table.scan(scan_batching=...)
106dcf0 
For details, see the comments added in this commit, and issues #54 and
issue #56.
@wbolster wbolster mentioned this issue Feb 25, 2014
Closed
@wbolster
Copy link
Member Author

Should be fixed in 0.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wbolster