Add support for TCompactProtocol #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, this looks good in general. Few questions/remarks:
|
|
I think it supports it from 0.94 on. Or where ever framed transports were supported from. Thrift documentation is...spotty on the topic. |
|
You do have to add the "-c" flag for a stand-alone thrift server or hbase.regionserver.thrift.compact needs to be set to true on an integrated server. |
wbolster
added a commit
that referenced
this pull request
Oct 14, 2014
|
Thanks @johnseekins; I've merged your PR with a few minor changes stacked on top in 15b5311. I don't have any plans for a 0.9 release currently; do you want to me to release 0.9? |
|
FYI, I've released HappyBase 0.9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The difference between TBinaryAccelerated and TCompact (from Wikipedia):
TBinaryProtocol – A straightforward binary format, simple, but not optimized for space efficiency. Faster to process than the text protocol but more difficult to debug.
TCompactProtocol – More compact binary format; typically more efficient to process as well
Seems like this would be useful. It does, like framed transports, require configuration changes on the server end as well.