-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3 Compatibility #108
Conversation
…ate Hbase bindings using new definitions file.
…g and decoding of strings and bytes respectively, but also meant correcting imports and, in a couple cases, explicitly doing something different for Python 2 vs. Python 3.
…lueError instead of TypeError when passing None where an integral type is expected.
I've done some reading, and have found that most of the Hbase documentation conflicts with the comment in the Hbase.thrift file that suggests that keys, values, etc. should be UTF-8. I'm closing this pull request, and will make another pull request which accepts bytes() instances in Python 3. |
@surfacepatterns keep it up. Would really like to see python3 support even if it doesn't make it into master. |
Created a new pull request that does the right thing. |
yeah data is always bytes and happybase should NOT accept anything else. helper methods like table names or keys in config dicts are a different story, accepting "native" strings makes sense wherever reasonable.
sent from my phone. please forgive my tpyos. On March 10, 2016 10:16:12 PM GMT+01:00, Devin Anderson notifications@github.com wrote:
|
it will make it into master. i have a dislike for py2 nowadays 😉
sent from my phone. please forgive my tpyos. On March 10, 2016 10:27:21 PM GMT+01:00, Scott Cooper notifications@github.com wrote:
|
Even though I'm making a pull request, it's probably not reasonable to accept the pull request yet. I say this because:
In consequence, I'd probably wait for a new release of Thrift before accepting the pull request.
Aside from that, I should say a few things about my changes:
Let me know if you have any questions.