Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Wide columns in CRD #289

Merged
merged 1 commit into from
Sep 4, 2019
Merged

Add Wide columns in CRD #289

merged 1 commit into from
Sep 4, 2019

Conversation

nil-scan
Copy link
Contributor

@nil-scan nil-scan commented Sep 3, 2019

Adds FailedChecks, Interval, StepWeight and MaxWeight columns when using the wide output format.
I find them useful to understand how the canary is progressing and when it's expected to finish.

I can revert the single quote to double quote changes if needed

stefanprodan
stefanprodan approved these changes Sep 4, 2019
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @nilscan

@stefanprodan stefanprodan merged commit 5e40340 into fluxcd:master Sep 4, 2019
@stefanprodan stefanprodan mentioned this pull request Sep 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nil-scan @stefanprodan