This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Make port forward label selector configurable #1727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes the label selectors fluxctl uses for port forwarding configurable by providing a `--k8s-fwd-labels` flag or setting a `FLUX_FORWARD_LABELS` environment variable. The default value of the flag is inherited from the hardcoded value it was before (`app=flux`).
stefanprodan
approved these changes
Feb 12, 2019
|
If I run flux as usual (for me), and use ... I still get a result, rather than a failure to set up the port forward. I think that's because it'll still try the selector |
|
@squaremo fixed by prioritizing configured labels over the 'default' ones. $ kubectl get pods
NAME READY STATUS RESTARTS AGE
flux-b7f875769-pt47z 1/1 Running 0 6m9s
flux2-595894f954-rfvmj 1/1 Running 0 6m1s
$ fluxctl identity
ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDBzW2o8fej6c+YwS5vWuEeCFNmh2+vExYS7/40UCSynMPumtDlkaa49zvMN+g124KZwc7lrFC+5E21jZEA81OG1i0UER/OwRX/Nla59/jJDASIjKUhE1EnJGj9ZxIUo42ap3Mt5F/bAWkllGlCCAFFzKEcn/DQUdWf6LPQZ5FiM+k0tMOjkMiOyTGIcPD+O13HzR++pOIhFKSYgPKVUI9/MMZuAJCFOKJlgcu770whp9WEDCyq1xHShh8CA9uj/nDzjGz2VAq09/1BifVeoAyusaiNodMHBTqJRbEhfwRGIN6WG2nyUaHbt8VY+P/XHMnEk0S9rCdqhdN/hx7bRDJJ
$ fluxctl identity --k8s-fwd-labels name=flux2
ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDawuDr59SWJ5VhVJFPOSRg1L0k6cv1N6esZKdA2OsqU6kdOPaUzTj1NPyNIc65psX2WWqpL77CKMjfdkNZrjMlBETlTBCQIhK44Zi3uI51e7amH8LYvoV3+5xGtyV1tGL72n9gEzRtB8gayzpk5fJ9nFp71bnX/wGfelT8p/5pf9LPLXIh8z5wpU0+Pw4ne5maLuj0zWh270oDEn9TahoJQlu1v3vRuJm8rIWkEEFMymZLw0RFF08KyUlLuHgBeHg4xKPPgpKXfJ0WMAtkTdKAlZUTcBSQ9ke79YEGR827dHwZzO9lN4vdTia6UUO6unkYi9CUKBO1czo/SumI7Fj/
$ fluxctl identity --k8s-fwd-labels name=flux
ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDBzW2o8fej6c+YwS5vWuEeCFNmh2+vExYS7/40UCSynMPumtDlkaa49zvMN+g124KZwc7lrFC+5E21jZEA81OG1i0UER/OwRX/Nla59/jJDASIjKUhE1EnJGj9ZxIUo42ap3Mt5F/bAWkllGlCCAFFzKEcn/DQUdWf6LPQZ5FiM+k0tMOjkMiOyTGIcPD+O13HzR++pOIhFKSYgPKVUI9/MMZuAJCFOKJlgcu770whp9WEDCyq1xHShh8CA9uj/nDzjGz2VAq09/1BifVeoAyusaiNodMHBTqJRbEhfwRGIN6WG2nyUaHbt8VY+P/XHMnEk0S9rCdqhdN/hx7bRDJJ |
squaremo
approved these changes
Feb 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the label selectors
fluxctluses for port forwarding configurable by providing a--k8s-fwd-labelsflag or setting aFLUX_FORWARD_LABELSenvironment variable. The default value of the flag is inherited from the hardcoded value it was before (app=flux).Fixes #1700