This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Enhances git command tracing #1844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
squaremo
suggested changes
Mar 25, 2019
dimitropoulos
force-pushed
the
traceGitCommands
branch
3 times, most recently
from
6d76536 to
f4fe471
Compare
|
@squaremo I updated to satisfy all the changes you requested. Let me know if anything else jumps out at you. :) |
dimitropoulos
force-pushed
the
traceGitCommands
branch
from
f4fe471 to
7132fad
Compare
squaremo
reviewed
Mar 26, 2019
squaremo
reviewed
Mar 26, 2019
squaremo
reviewed
Mar 26, 2019
dimitropoulos
force-pushed
the
traceGitCommands
branch
from
312caaf to
612be0d
Compare
squaremo
reviewed
Mar 26, 2019
dimitropoulos
force-pushed
the
traceGitCommands
branch
from
612be0d to
5f904c8
Compare
squaremo
approved these changes
Mar 26, 2019
allows for blacklisting certain git commands from tracing changes requested from review changes from recent review
dimitropoulos
force-pushed
the
traceGitCommands
branch
from
5f904c8 to
ca753f4
Compare
squaremo
reviewed
Mar 26, 2019
squaremo
approved these changes
Mar 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently a very basic mechanism built in to
execGitCmdthat is essential in certain kinds of debugging for tracing the git commands that the application is using. Recently in work on a separate PR, I needed to view the output of the git commands. On top of that, some frequent commands (such as the twogit configlines that occur almost every time a flux action occurs) make it hard to quickly zero in on what you're looking for.This PR adds:
const trace = true(as before) will now output a more parse-friendly log line that also includes the output of the git command.