Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Fix instructions for observing colour change #1912

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Fix instructions for observing colour change #1912

merged 1 commit into from
Apr 10, 2019

Conversation

dholbach
Copy link
Member

@dholbach dholbach commented Apr 9, 2019 

In #1902 it was discovered that the part of the tutorial where
PODINFO_UI_COLOR was changed didn't actually work. So we're
using the same instructions as in the Helm tutorial now, modulo
the namespace (default vs flux) change.

@dholbach dholbach requested a review from 2opremio April 9, 2019 10:39
@dholbach dholbach self-assigned this Apr 9, 2019
@dholbach dholbach added the docs Issue or PR relates to documentation label Apr 9, 2019
@dholbach
Copy link
Member Author

dholbach commented Apr 9, 2019

cc @stefanprodan

@stefanprodan
Copy link
Member

@dholbach how did you test the color change? If you use curl it should return a json with the right color

@dholbach
Copy link
Member Author

dholbach commented Apr 9, 2019

@dholbach how did you test the color change? If you use curl it should return a json with the right color

I opened it in a browser. It was still green.

@dholbach
Copy link
Member Author

dholbach commented Apr 9, 2019

@dholbach how did you test the color change? If you use curl it should return a json with the right color

I opened it in a browser. It was still green.

https://github.com/weaveworks/flux/pull/1912/files#diff-15622267c2ec3db7451cdecfe25640b9L138

@stefanprodan
Copy link
Member

The color in the browser is determine in JS based on the version number. Try curl

Use curl to test color value in JSON reply
121c8ac 
	In #1902 it was identified that the podinfo HTML
	did not change colour. If you use curl to get the
	JSON reply, the  color  value is updated though.
@dholbach
Copy link
Member Author

dholbach commented Apr 9, 2019

Updated based on your feedback @stefanprodan - thanks!

@dholbach dholbach requested a review from stefanprodan April 9, 2019 13:31
@dholbach dholbach changed the title Copy over instructions from helm-get-started tutorial Fix instructions for observing colour change Apr 10, 2019
@dholbach dholbach requested a review from hiddeco April 10, 2019 09:54
@dholbach dholbach merged commit 85bcb12 into fluxcd:master Apr 10, 2019
@dholbach dholbach deleted the fix-part-two-of-1902 branch April 10, 2019 09:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hiddeco hiddeco hiddeco approved these changes

@2opremio 2opremio Awaiting requested review from 2opremio

@stefanprodan stefanprodan Awaiting requested review from stefanprodan

Assignees

@dholbach dholbach

Labels
docs Issue or PR relates to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dholbach @stefanprodan @hiddeco