-
Notifications
You must be signed in to change notification settings - Fork 1.1k
add snapcraft.yaml for Linux packages of fluxctl #1966
Conversation
https://forum.snapcraft.io/t/fluxctl-snap-want-to-be-classic/11073/2 is the current stand of things. |
Apparently we don't need classic confinement. |
What're the minikube files mentioned in the YAML @dholbach ? |
They're not really required. Removing. |
@squaremo Apparently, they're needed after all:
|
What about people that aren't using minikube? What exactly is the purpose of that section of the YAML? |
This part of the YAML allows |
The package was approved in the Snap store. I pushed it to the Running Next step would be to hook it up with our build infrastructure. |
Great job @dholbach !!! |
Maybe let's merge this as is for now and then solve whatever's required for publishing master builds to |
closes #1377 Signed-off-by: Daniel Holbach <daniel@weave.works>
I pushed a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not aware of the details of snapcraft.yaml
files, but bash / command wise this looks OK to me. Thanks Daniel 🌷
This creates a snap of
fluxctl
, prerequisite is:Next step would be
classicpersonal-files
permissions (https://forum.snapcraft.io/c/store-requests)and classic permissionsapprovedhook this up with the build infrastructure→ moving this to a new issue/OR