Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

add snapcraft.yaml for Linux packages of fluxctl #1966

Merged
merged 14 commits into from
May 27, 2019
Merged

add snapcraft.yaml for Linux packages of fluxctl #1966

merged 14 commits into from
May 27, 2019

Conversation

dholbach
Copy link
Member

@dholbach dholbach commented Apr 23, 2019

This creates a snap of fluxctl, prerequisite is:

sudo snap install snapcraft --classic
sudo snap install multipass --beta --classic
snapcraft

Next step would be

  • register on Snap store
  • push initial snap of 'edge' release (current HEAD)
  • ask for classic personal-files permissions (https://forum.snapcraft.io/c/store-requests)
  • get package and classic permissions approved
  • hook this up with the build infrastructure → moving this to a new issue/OR

@dholbach
Copy link
Member Author

https://forum.snapcraft.io/t/fluxctl-snap-want-to-be-classic/11073/2 is the current stand of things.

@dholbach
Copy link
Member Author

dholbach commented May 8, 2019

Apparently we don't need classic confinement.

@squaremo
Copy link
Member

squaremo commented May 9, 2019

What're the minikube files mentioned in the YAML @dholbach ?

@dholbach
Copy link
Member Author

They're not really required. Removing.

@dholbach
Copy link
Member Author

@squaremo Apparently, they're needed after all:

[daniel@reef flux ]$ fluxctl identity
Error: Could not load kubernetes configuration file: invalid configuration: [unable to read client-cert /home/daniel/.minikube/client.crt for minikube due to open /home/daniel/.minikube/client.crt: permission denied, unable to read client-key /home/daniel/.minikube/client.key for minikube due to open /home/daniel/.minikube/client.key: permission denied, unable to read certificate-authority /home/daniel/.minikube/ca.crt for minikube due to open /home/daniel/.minikube/ca.crt: permission denied]
Run 'fluxctl identity --help' for usage.
[daniel@reef flux ]$ 

@squaremo
Copy link
Member

they're needed after all

What about people that aren't using minikube? What exactly is the purpose of that section of the YAML?

@dholbach
Copy link
Member Author

dholbach commented May 14, 2019

This part of the YAML allows fluxctl to read these files (https://docs.snapcraft.io/personal-files-interface).

@dholbach
Copy link
Member Author

The package was approved in the Snap store. I pushed it to the edge channel.

Running snap install --edge fluxctl will download and install it. Testing welcome.

Next step would be to hook it up with our build infrastructure.

@2opremio
Copy link
Contributor

Great job @dholbach !!!

@dholbach dholbach marked this pull request as ready for review May 22, 2019 09:09
@dholbach
Copy link
Member Author

Maybe let's merge this as is for now and then solve whatever's required for publishing master builds to edge and tagged commits to stable.

@dholbach
Copy link
Member Author

I pushed a stable (1.12.3) fluxctl to the store now too. Time to hook things up with CI.

Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not aware of the details of snapcraft.yaml files, but bash / command wise this looks OK to me. Thanks Daniel 🌷

@dholbach dholbach merged commit bc46702 into fluxcd:master May 27, 2019
@dholbach dholbach deleted the add-snaps branch May 27, 2019 14:22
@hiddeco hiddeco added this to the v1.13.0 milestone May 30, 2019
@dholbach dholbach mentioned this pull request Jun 24, 2019
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants