Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Refactor the SSH field in v1alpha2 #185

Open
luxas opened this issue Jul 15, 2019 · 2 comments
Open

Refactor the SSH field in v1alpha2 #185

luxas opened this issue Jul 15, 2019 · 2 comments
Labels
api/v1alpha3 kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API priority/backlog Higher priority than priority/awaiting-more-evidence.
Milestone

Comments

@luxas
Copy link
Contributor

luxas commented Jul 15, 2019

@luxas luxas added api/v1alpha2 kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API priority/backlog Higher priority than priority/awaiting-more-evidence. labels Jul 15, 2019
@luxas luxas modified the milestones: v0.5.0, v1alpha2 Jul 15, 2019
@luxas
Copy link
Contributor Author

luxas commented Aug 8, 2019

@twelho wrote in #152:

In FIPS-enabled machines the ed25519 key generation algorithm is unavailable, so they need to use rsa.

Let the user specify the algorithm to use via a flag during VM creation
Improve autodetection for FIPS machines to automatically switch over to rsa
Enforce a specific key length (between 2048 and 4096) when using rsa

We'll most likely fix this in v1alpha2, but I'm not certain we have the time.
I'm not sure if we should keep the auto-detection of the SSH key algorithm, or just "blindly" use what we got from the API. An other alternative would be to try to generate an ed25519 key and if that fails, fallback on rsa.
Anyways, this code needs some love.

@luxas
Copy link
Contributor Author

luxas commented Aug 9, 2019

After thinking about this, it's not high-priority enough to do in v1alpha2 / v0.5.0. Moving to v1alpha3.

@luxas luxas modified the milestones: v1alpha2, v1alpha3 Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api/v1alpha3 kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

1 participant