Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Consider adding ignite exec [vm] [command] #65

Closed
luxas opened this issue Jun 10, 2019 · 4 comments · Fixed by #232
Closed

Consider adding ignite exec [vm] [command] #65

luxas opened this issue Jun 10, 2019 · 4 comments · Fixed by #232
Labels
area/UX Let's make Ignite's UX great! contributor-assigned This issue has been assigned to a contributor kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Milestone

Comments

@luxas
Copy link
Contributor

luxas commented Jun 10, 2019

It would:
a) use ssh internally
b) require a command, unlike ssh

Don't know if we want to do this or not

@luxas luxas changed the title Maybe consider add ignite exec [vm] [command] Consider adding ignite exec [vm] [command] Jun 10, 2019
@BenTheElder
Copy link
Contributor

This would be pretty useful for my use cases, especially if it preserved the exit code :-)

I took a quick look, this seems doable, any thoughts on why we might not want this?

@luxas luxas added this to the v0.5.0 milestone Jul 15, 2019
@luxas
Copy link
Contributor Author

luxas commented Jul 15, 2019

Ok, great!
Let's add it to the v0.5.0 milestone.
Can you help out with making it happen?

@luxas luxas added kind/feature Categorizes issue or PR as related to a new feature. area/UX Let's make Ignite's UX great! priority/backlog Higher priority than priority/awaiting-more-evidence. labels Jul 15, 2019
@BenTheElder
Copy link
Contributor

Yes, I think I can help with this!

Side note: WDYT about https://godoc.org/golang.org/x/crypto/ssh ? I'm pretty sure go has decent SSH clients that we could use to avoid manipulating the host machine's known hosts etc. EG https://godoc.org/golang.org/x/crypto/ssh#Dial

@luxas
Copy link
Contributor Author

luxas commented Jul 17, 2019

Yes, I think I can help with this!

Wonderful, thank you!

Side note: WDYT about https://godoc.org/golang.org/x/crypto/ssh ? I'm pretty sure go has decent SSH clients that we could use to avoid manipulating the host machine's known hosts etc. EG https://godoc.org/golang.org/x/crypto/ssh#Dial

Thanks for the pointer! I've never used it (yet!), but would be happy to do so. Exec'ing out to ssh was just the fastest way to implement this :)
I'll add this to #150

@luxas luxas added the contributor-assigned This issue has been assigned to a contributor label Jul 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/UX Let's make Ignite's UX great! contributor-assigned This issue has been assigned to a contributor kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants