Skip to content

Commit

Permalink
don't show container count in host detail panel image list
Browse files Browse the repository at this point in the history
The figure is inaccurate since it counts containers across all
hosts. Getting the count correct is non-trivial, so it's better to not
show the figure at all.

NB: the count still shows up on mouse-over of the link, but that is
defensible and not (very) confusing since the link represents the
image, not the image on a particular host, and it's the same count
that show up as the minor label in the container images view.

Fixes #2681.
  • Loading branch information
rade committed Jul 5, 2017
1 parent a0fb2e1 commit 0f4d17d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 8 deletions.
6 changes: 2 additions & 4 deletions render/detailed/node.go
Original file line number Diff line number Diff line change
Expand Up @@ -175,10 +175,8 @@ var nodeSummaryGroupSpecs = []struct {
{
topologyID: report.ContainerImage,
NodeSummaryGroup: NodeSummaryGroup{
Label: "Container Images",
Columns: []Column{
{ID: report.Container, Label: "# Containers", DefaultSort: true, Datatype: "number"},
},
Label: "Container Images",
Columns: []Column{},
},
},
}
Expand Down
6 changes: 2 additions & 4 deletions render/detailed/node_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -132,10 +132,8 @@ func TestMakeDetailedHostNode(t *testing.T) {
{
Label: "Container Images",
TopologyID: "containers-by-image",
Columns: []detailed.Column{
{ID: report.Container, Label: "# Containers", DefaultSort: true, Datatype: "number"},
},
Nodes: []detailed.NodeSummary{containerImageNodeSummary},
Columns: []detailed.Column{},
Nodes: []detailed.NodeSummary{containerImageNodeSummary},
},
},
Connections: []detailed.ConnectionsSummary{
Expand Down

0 comments on commit 0f4d17d

Please sign in to comment.