refactor: lift some code out of inner loop

weaveworks · Dec 26, 2017 · 15155d0 · 15155d0
1 parent 5c77099
commit 15155d0
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/render/detailed/parents.go b/render/detailed/parents.go
@@ -39,6 +39,10 @@ func Parents(r report.Report, n report.Node) []Parent {
 		if !ok {
 			continue
 		}
+		apiTopologyID, ok := primaryAPITopology[topologyID]
+		if !ok {
+			continue
+		}
 		parents, _ := n.Parents.Lookup(topologyID)
 		for _, id := range parents {
 			if topologyID == n.Topology && id == n.ID {
@@ -48,10 +52,6 @@ func Parents(r report.Report, n report.Node) []Parent {
 			if !ok {
 				parentNode = report.MakeNode(id).WithTopology(topologyID)
 			}
-			apiTopologyID, ok := primaryAPITopology[topologyID]
-			if !ok {
-				continue
-			}
 			if summary, ok := MakeBasicNodeSummary(r, parentNode); ok {
 				result = append(result, Parent{
 					ID:         summary.ID,