Skip to content

Commit

Permalink
Merge pull request #944 from weaveworks/slow-report-generation-logging
Browse files Browse the repository at this point in the history
log a warning when reporters or taggers take too long to generate
  • Loading branch information
Alfonso Acosta committed Feb 8, 2016
2 parents bf3d92f + 6c16beb commit 37e57dd
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions probe/probe.go
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,9 @@ func (p *Probe) report() report.Report {
for _, rep := range p.reporters {
go func(rep Reporter) {
t := time.Now()
timer := time.AfterFunc(p.spyInterval, func() { log.Warningf("%v reporter took longer than %v", rep.Name(), p.spyInterval) })
newReport, err := rep.Report()
timer.Stop()
metrics.MeasureSince([]string{rep.Name(), "reporter"}, t)
if err != nil {
log.Errorf("error generating report: %v", err)
Expand All @@ -154,7 +156,9 @@ func (p *Probe) tag(r report.Report) report.Report {
var err error
for _, tagger := range p.taggers {
t := time.Now()
timer := time.AfterFunc(p.spyInterval, func() { log.Warningf("%v tagger took longer than %v", tagger.Name(), p.spyInterval) })
r, err = tagger.Tag(r)
timer.Stop()
metrics.MeasureSince([]string{tagger.Name(), "tagger"}, t)
if err != nil {
log.Errorf("error applying tagger: %v", err)
Expand Down

0 comments on commit 37e57dd

Please sign in to comment.