Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add netgo guard to the Makefile #103

Closed
tomwilkie opened this issue May 26, 2015 · 4 comments · Fixed by #110
Closed

Add netgo guard to the Makefile #103

tomwilkie opened this issue May 26, 2015 · 4 comments · Fixed by #110
Assignees

Comments

@tomwilkie
Copy link
Contributor

Its still building a dynamically linked binary

# docker run -ti --entrypoint /bin/sh weaveworks/scope
/home/weave # ldd app
        /lib64/ld-linux-x86-64.so.2 (0x7ff40faba000)
        libpthread.so.0 => /lib64/ld-linux-x86-64.so.2 (0x7ff40faba000)
        libc.so.6 => /lib64/ld-linux-x86-64.so.2 (0x7ff40faba000)
@tomwilkie
Copy link
Contributor Author

Output from offending build:

https://gist.github.com/peterbourgon/7d7c7262688144e0f719

@tomwilkie
Copy link
Contributor Author

Problem is people need to run

go clean -i net
go install -tags netgo std

@tomwilkie
Copy link
Contributor Author

Weave Makefile has a stanza to catch this:

    @strings $@ | grep cgo_stub\\\.go >/dev/null || { \
        rm $@; \
        echo "\nYour go standard library was built without the 'netgo' build tag."; \
        echo "To fix that, run"; \
        echo "    sudo go clean -i net"; \
        echo "    sudo go install -tags netgo std"; \
        false; \
    }

We should include that.

@peterbourgon
Copy link
Contributor

That fixes it.

@peterbourgon peterbourgon changed the title Scope doesn't build right... Add netgo guard to the Makefile May 26, 2015
@tomwilkie tomwilkie self-assigned this May 26, 2015
bboreham added a commit that referenced this issue Jul 13, 2017
74dc626 Merge pull request #108 from weaveworks/disable-apt-daily
b4f1d91 Merge pull request #107 from weaveworks/docker-17-update
7436aa1 Override apt daily job to not run immediately on boot
7980f15 Merge pull request #106 from weaveworks/document-docker-install-role
f741e53 Bump to Docker 17.06 from CE repo
61796a1 Update Docker CE Debian repo details
0d86f5e Allow for Docker package to be named docker-ce
065c68d Document selection of Docker installation role.
3809053 Just --porcelain; it defaults to v1
11400ea Merge pull request #105 from weaveworks/remove-weaveplugin-remnants
b8b4d64 remove weaveplugin remnants
35099c9 Merge pull request #104 from weaveworks/pull-docker-py
cdd48fc Pull docker-py to speed tests/builds up.
e1c6c24 Merge pull request #103 from weaveworks/test-build-tags
d5d71e0 Add -tags option so callers can pass in build tags
8949b2b Merge pull request #98 from weaveworks/git-status-tag
ac30687 Merge pull request #100 from weaveworks/python_linting
4b125b5 Pin yapf & flake8 versions
7efb485 Lint python linting function
444755b Swap diff direction to reflect changes required
c5b2434 Install flake8 & yapf
5600eac Lint python in build-tools repo
0b02ca9 Add python linting
c011c0d Merge pull request #79 from kinvolk/schu/python-shebang
6577d07 Merge pull request #99 from weaveworks/shfmt-version
00ce0dc Use git status instead of diff to add 'WIP' tag
411fd13 Use shfmt v1.3.0 instead of latest from master.
31d069d Change Python shebang to `#!/usr/bin/env python`

git-subtree-dir: tools
git-subtree-split: 74dc626b6de3ffb38591510f7cb7bc2db33743c4
leth pushed a commit that referenced this issue Aug 28, 2018
Changes:
- Default diff-printer to hide details (#103) - da4c3ff
- Improve logging of http errors (#115) - f5a1710
- Update httpgrpc to match cortexproject/cortex#910 (#117) - 80ff076
- Expose the HTTP server from the server struct. (#118) - 1a7a6b3
- Add HTTP tracing middleware (#119) - d442d08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants