Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Weave Scope is reachable at..." lies when app address is changed #1190

Closed
rade opened this issue Mar 21, 2016 · 0 comments
Closed

"Weave Scope is reachable at..." lies when app address is changed #1190

rade opened this issue Mar 21, 2016 · 0 comments
Assignees
@rade
Labels
accuracy Incorrect information is being shown to the user; usually a bug bug Broken end user or developer functionality; not working as the developers intended it
Milestone
Backlog

Comments

@rade
Copy link
Member

rade commented Mar 21, 2016 

$ scope version
Weave Scope version b5da2e4
$ scope launch --app.http.address=127.0.0.1:4041
abf9d4d730dec730a62bd11889116d256088b621bafe22630ff6a9fd66912d5e
Weave Scope is reachable at the following URL(s):
  * http://192.168.1.65:4040/
  * http://192.168.48.1:4040/

The output is a complete lie; the app is in fact reachable exactly where I told it.
@rade rade added the bug Broken end user or developer functionality; not working as the developers intended it label Mar 21, 2016
@rade rade changed the title "Weave Scope is reachable at..." output complete wrong when app address is changed "Weave Scope is reachable at..." lies when app address is changed Mar 21, 2016
@rade rade mentioned this issue Mar 21, 2016
Closed
@tomwilkie tomwilkie added this to the Pre-1.0 milestone Apr 11, 2016
@rade rade mentioned this issue May 3, 2016
Closed
@rade rade modified the milestone: Pre-1.0 Jul 4, 2016
@tomwilkie tomwilkie mentioned this issue Jul 14, 2016
Closed
@rade rade added this to the Backlog milestone Dec 12, 2016
@2opremio 2opremio mentioned this issue Dec 16, 2016
Merged
@rade rade added the accuracy Incorrect information is being shown to the user; usually a bug label Jan 11, 2017
@rade rade self-assigned this Apr 14, 2017
rade added a commit that referenced this issue Apr 14, 2017
@rade
don't lie about reachable address
bb36067 
when app.http.address is specified. Instead just tell the user that
scope is reachable where they said.

Also, complain when the address is specified on D4M since there are
a bunch of hard-coded port 4040 in place for that.

Fixes #1190.
@rade rade mentioned this issue Apr 14, 2017
Merged
rade added a commit that referenced this issue Apr 15, 2017
@rade
Merge pull request #2443 from weaveworks/1190-app-http-address
c924e81 
don't lie about reachable address

Fixes #1190.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rade rade

Labels
accuracy Incorrect information is being shown to the user; usually a bug bug Broken end user or developer functionality; not working as the developers intended it
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@rade @tomwilkie