New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Pipe interface into Pipe app and probe sides #1215

Open

2opremio opened this issue Mar 30, 2016 · 1 comment

Labels

tech-debt

Contributor

2opremio commented Mar 30, 2016

Followup on #1208 (comment)

2opremio added the tech-debt label

2opremio mentioned this issue

host-level ttys #1208

Merged

Contributor Author

2opremio commented Mar 31, 2016

Other things to take into account:

The end passed toCopyToWebsocket() should probably be implicit.
Close() should probably close the pipes ~~and we should consider whether OnClose() is really necessary.~~ (I think it is needed in case the pipe is closed from the other end)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment