Allow user to override app and probe default port

[tomwilkie]

No description provided.

[peterbourgon]

Why?

I mean they already can, with the commandline flags...

[tomwilkie]

Just in case port 4040 and 4030 are already in use locally.

I think it came up in conversation when I was encouraging people to give
feedback, but I don't remember who mentioned it.

On Tuesday, 2 June 2015, Peter Bourgon notifications@github.com wrote:

Why?

—
Reply to this email directly or view it on GitHub
#153 (comment).

[peterbourgon]

Gotcha. How would you change that, via the scope script?

[tomwilkie]

With the scope script, any extra arguments are just passed to the
container's entrypoint.sh script.

I'm thinking in entrypoint.sh, munging any arguments starting with -probe.
into a file /etc/weave/probe-args, and similar for the app. Then in
run-app and run-probe, read these files and tack them onto the command,
similar to how we handle having hosts passed right now.

What do you think?

On Wed, Jun 3, 2015 at 8:14 AM, Peter Bourgon notifications@github.com
wrote:

Gotcha. How would you change that, via the scope script?

—
Reply to this email directly or view it on GitHub
#153 (comment).

[peterbourgon]

I like the idea of using a flag prefix and parsing it in the scope script, but there's got to be a nicer way than dumping them to text files in the container and dumping them out again in the run scripts?

[tomwilkie]

Depends on what runit supports. Dumping the flags to a file seems the
easiest to me.

On Wednesday, 3 June 2015, Peter Bourgon notifications@github.com wrote:

I like the idea of using a flag prefix and parsing it in the scope script,
but there's got to be a nicer way than dumping them to text files in the
container and dumping them out again in the run scripts?

—
Reply to this email directly or view it on GitHub
#153 (comment).

[davkal]

Definitely need to change UI dev server port from 3000 to 404x.
:3000 is just too common.

[peterbourgon]

I guess I'm wondering if there's a better way to pass information through the host—Docker membrane. Environment variables? Probably too finicky. Yeah, maybe files are the least-bad option.

[tomwilkie]

The command line is used for the "host—Docker membrane". Its within the container, passing variables from entrypoint.sh to the run-foo scripts that requires the file.

[peterbourgon]

Sorry, yes, that's what I meant.