Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unmangaged/uncontained clutter view by default #1689

Closed
rade opened this issue Jul 16, 2016 · 3 comments
Closed

unmangaged/uncontained clutter view by default #1689

rade opened this issue Jul 16, 2016 · 3 comments
Assignees
@rade
Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer
Milestone
0.17.0

Comments

@rade
Copy link
Member

rade commented Jul 16, 2016

By default we show uncontained/unmanaged containers in the topology. In many cases this clutters the view and makes for a bad first impression. See our public demo for an example.

Hence I reckon we should hide unmanaged/uncontained by default.
@rade rade added component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer chore Related to fix/refinement/improvement of end user or new/existing developer functionality labels Jul 16, 2016
@rade
Copy link
Member Author

rade commented Jul 16, 2016

@davkal @foot any clues where in the code the default is determined? I can't even work out whether it's f/e or b/e.

@rade rade self-assigned this Jul 17, 2016
rade added a commit that referenced this issue Jul 17, 2016
@rade
hide uncontained/unmanaged by default
3202cc7 
They are of no interest to most users and affect the initial user
experience.

Fixes #1689.
@rade rade added this to the July2016 milestone Jul 17, 2016
@rade rade mentioned this issue Jul 17, 2016
Merged
@foot
Copy link
Contributor

foot commented Jul 18, 2016

In the BE!

https://github.com/weaveworks/scope/blob/c80eb42/app/api_topologies.go#L56

@rade
Copy link
Member Author

rade commented Jul 18, 2016

@foot see PR #1694 :)

rade added a commit that referenced this issue Jul 18, 2016
@rade
Merge pull request #1694 from weaveworks/1689-hide-uncontained-by-def…
4a9e09b 
…ault

hide uncontained/unmanaged by default

Fixes #1689.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rade rade

Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer
Projects
None yet
Milestone
0.17.0
Development

No branches or pull requests
2 participants
@foot @rade