Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need means to reset localStorage view state #1872

Closed
davkal opened this issue Sep 19, 2016 · 2 comments
Closed

Need means to reset localStorage view state #1872

davkal opened this issue Sep 19, 2016 · 2 comments
Assignees
Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer help-wanted An issue that would be good for non-maintainers to attempt
Milestone

Comments

@davkal
Copy link
Contributor

davkal commented Sep 19, 2016

Aftermath of #1853

This is a bit edge casey but do you think we need some kind of localStorage recovery story? If you have a terminal open, notice some bug we've introduced which crashes the app...

refresh will reload that bad state from the url
clearing the url will now also load the app into a bad state from localStorage

@davkal davkal added component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer chore Related to fix/refinement/improvement of end user or new/existing developer functionality labels Sep 19, 2016
@davkal davkal added the help-wanted An issue that would be good for non-maintainers to attempt label Oct 14, 2016
@jpellizzari
Copy link
Contributor

jpellizzari commented Nov 2, 2016

@davkal how about another little icon in the bottom right that would clear localStorage's view state then reload the page without any state in the URL.

Something like this:
1872
It could say "Clear UI State" on hover maybe.

Or, we could add a keyboard shortcut that would have the same behavior.

@davkal
Copy link
Contributor Author

davkal commented Nov 10, 2016

I would put the Clear UI state button in the help window. Of all the icons, it will be used the least often, by orders of magnitude. Maybe create a new section in the lower part of the help window?

@jpellizzari jpellizzari self-assigned this Dec 8, 2016
@rade rade added this to the EOY 2016 milestone Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer help-wanted An issue that would be good for non-maintainers to attempt
Projects
None yet
Development

No branches or pull requests

3 participants