Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honor DOCKER_HOST in the probes #1975

Closed
2opremio opened this issue Nov 3, 2016 · 2 comments
Closed

Honor DOCKER_HOST in the probes #1975

2opremio opened this issue Nov 3, 2016 · 2 comments
Labels
bug Broken end user or developer functionality; not working as the developers intended it
Milestone
Backlog

Comments

@2opremio
Copy link
Contributor

2opremio commented Nov 3, 2016

Right now we hardcode the docker endpoint to unix:///var/run/docker.sock
@2opremio 2opremio added the bug Broken end user or developer functionality; not working as the developers intended it label Nov 3, 2016
@2opremio 2opremio added this to the November2016 milestone Nov 3, 2016
@2opremio 2opremio mentioned this issue Nov 3, 2016
Merged
@rade
Copy link
Member

rade commented Jan 11, 2017

#1626 is related.

@rndstr
Copy link
Contributor

rndstr commented Jun 21, 2017

@2opremio regarding your comment:

However, this won't be the usecase since scope also needs to live in the machine being monitored (it needs /proc and conntrack for instance)

Does it even make sense to honor $DOCKER_HOST automatically? Will this lead to confusion if $DOCKER_HOST is unexpectedly set and /proc and conntrack are not from the same host? I could think of an explicit -probe.docker.env=true to alleviate this in case that's an issue, otherwise we could just go with auto-detection. Wdyt?

rndstr added a commit that referenced this issue Jun 26, 2017
@rndstr
Honor DOCKER_* env variables in probe and app
50087db 
Changed default for flag -app.docker to use the DOCKER_* env variables
instead of hardcoded /var/run/docker.sock; uses docker's default if
no DOCKER_HOST defined, for both probe and app.

Fixes #1975
rndstr added a commit that referenced this issue Jun 26, 2017
@rndstr
Honor DOCKER_* env variables in probe and app
927bb25 
Changed default for flag `-app.docker` to use the DOCKER_* env variables
instead of hardcoded /var/run/docker.sock; uses docker's default if
no DOCKER_HOST defined, for both probe and app.

Fixes #1975
@rndstr rndstr mentioned this issue Jun 26, 2017
Merged
rndstr added a commit that referenced this issue Jun 27, 2017
@rndstr
Honor DOCKER_* env variables in probe and app
651e52b 
Changed default for flag `-app.docker` to use the DOCKER_* env variables
instead of hardcoded /var/run/docker.sock; uses docker's default if
no DOCKER_HOST defined, for both probe and app.

Fixes #1975
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Broken end user or developer functionality; not working as the developers intended it
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@rndstr @rade @2opremio