Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect height of terminal window in Safari #1986

Closed
pidster opened this issue Nov 4, 2016 · 3 comments
Closed

Incorrect height of terminal window in Safari #1986

pidster opened this issue Nov 4, 2016 · 3 comments
Assignees
@jpellizzari
Labels
bug Broken end user or developer functionality; not working as the developers intended it
Milestone
1.0.0 (kubecon)

Comments

@pidster
Copy link
Contributor

pidster commented Nov 4, 2016

When launching the terminal control on a SockShop container in Safari (Version 10.0.1 (12602.2.14.0.7)), the height of the internal window is very small - barely 1 character high.

Chrome works OK. See screenshot below.

safari-scope
@pidster pidster added the bug Broken end user or developer functionality; not working as the developers intended it label Nov 4, 2016
@2opremio 2opremio added this to the kubecon milestone Nov 4, 2016
@jpellizzari jpellizzari self-assigned this Nov 4, 2016
@2opremio
Copy link
Contributor

2opremio commented Nov 4, 2016 •
edited
Loading

@jpellizzari As a reminder please create a PR on top of branch release-1.0 if you manage to fix this today.

@jpellizzari
Copy link
Contributor

Root cause of this appears to be Safari measuring innerNode.clientHeight differently from Chrome:
https://github.com/weaveworks/scope/blob/master/client/app/scripts/components/terminal.js#L274

jpellizzari added a commit that referenced this issue Nov 4, 2016
@jpellizzari
Fixed Safari terminal window height bug #1986
45e3296
@jpellizzari jpellizzari mentioned this issue Nov 4, 2016
Merged
@foot
Copy link
Contributor

foot commented Nov 7, 2016

Fixed in #1988

@foot foot closed this as completed Nov 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpellizzari jpellizzari

Labels
bug Broken end user or developer functionality; not working as the developers intended it
Projects
None yet
Milestone
1.0.0 (kubecon)
Development

No branches or pull requests
4 participants
@foot @pidster @2opremio @jpellizzari