Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to npm v4.0.5 or switch to using yarn #2090

Closed
fbarl opened this issue Dec 13, 2016 · 1 comment
Closed

Upgrade to npm v4.0.5 or switch to using yarn #2090

fbarl opened this issue Dec 13, 2016 · 1 comment
Assignees
Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality component/build An issue concerning compilation, testing, packaging, distribution component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer
Milestone

Comments

@fbarl
Copy link
Contributor

fbarl commented Dec 13, 2016

Supposedly due to this issue, we had a problem of having to run npm install twice, as the first run wouldn't pick up all the sub-dependencies of the library font-awesome-webpack that we use. That only became a breaking issue for some reason when merging #2058 into master, so that PR was reverted. #2089 restored the rolled-back code and moved font-awesome-webpack to devDependencies as a quick hack to the npm install issue.

However, font-awesome-webpack shouldn't really be in devDependencies, so a more proper solution should be used. @foot suggested following (from Slack conversation):

  1. Upgrading to npm v4.0.5 - https://github.com/npm/npm/releases/tag/v4.0.5
  2. Start using yarn - https://yarnpkg.com/
  3. Actually running npm install twice in the build process
  4. "align versions w/ deps? move to peerdeps? some npm voodoo"

IMO, both options 1 and 2 seem like a good way to go and they both worked well at the time of writing, but they would both imply changing the docker image.

I tried using yarn (see #2088), but CircleCI was having problems running it, supposedly due to this issue that got resolved in yarn (pre-release) version 0.18.0. Instructions on how to setup yarn with CircleCI: https://circleci.com/docs/install-and-use-yarn/

@2opremio 2opremio added chore Related to fix/refinement/improvement of end user or new/existing developer functionality component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer labels Dec 14, 2016
@rade rade modified the milestone: Backlog Jan 11, 2017
@rade rade added the component/build An issue concerning compilation, testing, packaging, distribution label Jan 11, 2017
@jpellizzari jpellizzari self-assigned this Jan 27, 2017
This was referenced Mar 21, 2017
@fbarl
Copy link
Contributor Author

fbarl commented Apr 18, 2017

Addressed by #2368.

@fbarl fbarl closed this as completed Apr 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality component/build An issue concerning compilation, testing, packaging, distribution component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer
Projects
None yet
Development

No branches or pull requests

4 participants