Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify report importing #2286

Open
2opremio opened this issue Feb 28, 2017 · 1 comment
Open

Simplify report importing #2286

2opremio opened this issue Feb 28, 2017 · 1 comment
Labels
feature Indicates that issue is related to new end user functionality
Milestone

Comments

@2opremio
Copy link
Contributor

2opremio commented Feb 28, 2017

A user came up with the following usecase:

freezing’ Scope’s view, so that I can ZIP up a static web site

We devs do this all the time for debugging by exporting the Scope report and loading it with a fixprobe. However, this is really tedious for end users.

I see a couple of alternatives to make this easier:

  1. Implement the fixprobe functionality in the UI. The UI can temporarily act as a fixprobe while the report is "imported". Some things would need to be resolved though: When to stop forwarding the report? What about other probes reporting at the same time? We may need to ask the app to ignore them temporarily, which won't be easy for weave cloud.
  2. Implement scope launch --diagnose=report.json. Which launches an app with a fixed probe.

While (1) is more flexible (it works with existing instances) it's also much more complicated, so I would go for (2).

An issue for both (1) and (2) is forward compatibility of the standalone app with newer report schemas (which we have never worried about). We can choose to ignore that problem for now.

@2opremio 2opremio added the chore Related to fix/refinement/improvement of end user or new/existing developer functionality label Feb 28, 2017
@2opremio 2opremio added this to the Backlog milestone Feb 28, 2017
@2opremio 2opremio changed the title Support for importing reports Add support for importing reports Feb 28, 2017
@2opremio 2opremio changed the title Add support for importing reports Simplify importing reports Feb 28, 2017
@2opremio 2opremio changed the title Simplify importing reports Simplify report importing Feb 28, 2017
@rade
Copy link
Member

rade commented Jul 14, 2017

We already almost can do (2), by invoking the scope binary directly, e.g.

prog/scope --mode=app --app.collector=file:/home/matthias/Downloads/report.json 

works, but the same doesn't work via a scope launch because the file isn't available inside the container. A new launch flag, along the lines suggested above, and parsed by the script could easily take care of mounting the file.

@rade rade added the feature Indicates that issue is related to new end user functionality label Jul 14, 2017
@rade rade removed the chore Related to fix/refinement/improvement of end user or new/existing developer functionality label Aug 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Indicates that issue is related to new end user functionality
Projects
None yet
Development

No branches or pull requests

2 participants