-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
host detail image container count is wrong #2681
Comments
rade
added
accuracy
Incorrect information is being shown to the user; usually a bug
bug
Broken end user or developer functionality; not working as the developers intended it
labels
Jul 5, 2017
This is clearly fixable, but a bit of a pain. Do we actually care (enough) about the counts? I suppose they might be useful for the same reason the containers-by-image view is useful - as a grouping for containers in the absence of orchestrator-induced grouping. |
rade
added a commit
that referenced
this issue
Jul 5, 2017
The figure isn't accurate since it counts containers across all hosts. Getting the count correct is non-trivial, so it's better to not show the figure at all. NB: the count still shows up on mousover of the link, but that is defensible and not (very) confusing since the link represents the image, not the image on a particular host, and it's the same count that show up as the minor label in the container images view. Fixes #2681.
rade
added a commit
that referenced
this issue
Jul 5, 2017
The figure is inaccurate since it counts containers across all hosts. Getting the count correct is non-trivial, so it's better to not show the figure at all. NB: the count still shows up on mouse-over of the link, but that is defensible and not (very) confusing since the link represents the image, not the image on a particular host, and it's the same count that show up as the minor label in the container images view. Fixes #2681.
rade
added a commit
that referenced
this issue
Jul 5, 2017
The figure is inaccurate since it counts containers across all hosts. Getting the count correct is non-trivial, so it's better to not show the figure at all. NB: the count still shows up on mouse-over of the link, but that is defensible and not (very) confusing since the link represents the image, not the image on a particular host, and it's the same count that show up as the minor label in the container images view. Fixes #2681.
rade
added a commit
that referenced
this issue
Jul 5, 2017
don't show container count in host detail panel image list Fixes #2681.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Following #2680, it's become apparent that the counts shown in the host detail image list - representing the number of containers running that image on that host - are wrong. Example:
The count is in fact the number of containers across all hosts running that image.
The bug arises quite straightforwardly...
Container images aren't tied to hosts, so in the scope report structure, an image node represents that image across all hosts and has as children the containers running that image on any of them.
The text was updated successfully, but these errors were encountered: