Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodes are merged poorly when restarting scope-app #2708

Closed
rndstr opened this issue Jul 12, 2017 · 0 comments
Closed

nodes are merged poorly when restarting scope-app #2708

rndstr opened this issue Jul 12, 2017 · 0 comments
Assignees
Labels
accuracy Incorrect information is being shown to the user; usually a bug bug Broken end user or developer functionality; not working as the developers intended it
Milestone

Comments

@rndstr
Copy link
Contributor

rndstr commented Jul 12, 2017

[split from #2646, see nodes in Graph View in screenshots]

The nodes are merged wrongly - here we should probably implement a mechanism that clears up the nodes after the probe reconnects and/or have smarter nodes delta merging.

@rndstr rndstr added this to the 1.6 milestone Jul 12, 2017
@rade rade added the bug Broken end user or developer functionality; not working as the developers intended it label Jul 12, 2017
@rndstr rndstr added the accuracy Incorrect information is being shown to the user; usually a bug label Jul 12, 2017
@rndstr rndstr self-assigned this Jul 12, 2017
rndstr added a commit that referenced this issue Jul 13, 2017
When the scope-app restarts, it no longer has a
reference to the previous node set. Therefore,
the delta update adds *all* nodes but does not
remove legacy ones.

`reset==true` tells the frontend to start fresh.

Fixes #2708
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accuracy Incorrect information is being shown to the user; usually a bug bug Broken end user or developer functionality; not working as the developers intended it
Projects
None yet
Development

No branches or pull requests

2 participants