Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dns names from endpoints to report level #3058

Closed
bboreham opened this issue Feb 5, 2018 · 0 comments
Closed

Move dns names from endpoints to report level #3058

bboreham opened this issue Feb 5, 2018 · 0 comments
Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality performance Excessive resource usage and latency; usually a bug or chore

Comments

@bboreham
Copy link
Collaborator

bboreham commented Feb 5, 2018

In large reports we can see many repeats of the same name lookup:

      ";10.244.252.166;42230": {
        "id": ";10.244.252.166;42230",
        "topology": "endpoint",
        "counters": null,
        "sets": {
          "reverse_dns_names": [
            "ip-10-244-252-166.ec2.internal"
          ]
        },
...
      ";10.244.252.166;42170": {
        "id": ";10.244.252.166;42170",
        "topology": "endpoint",
        "counters": null,
        "sets": {
          "reverse_dns_names": [
            "ip-10-244-252-166.ec2.internal"
          ]
        },
...
      ";10.244.252.166;42200": {
        "id": ";10.244.252.166;42200",
        "topology": "endpoint",
        "counters": null,
        "sets": {
          "reverse_dns_names": [
            "ip-10-244-252-166.ec2.internal"
          ]
        },
...

so we could have a structure up at Report level that mapped them once, then just look this up when we need it.
For backwards-compatibility we could create this structure in Report.Upgrade()

Relates to #1201

@bboreham bboreham added the performance Excessive resource usage and latency; usually a bug or chore label Feb 5, 2018
@rade rade added the chore Related to fix/refinement/improvement of end user or new/existing developer functionality label Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality performance Excessive resource usage and latency; usually a bug or chore
Projects
None yet
Development

No branches or pull requests

2 participants