Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move container labels from Latest #3086

Open
bboreham opened this issue Feb 23, 2018 · 1 comment
Open

Move container labels from Latest #3086

bboreham opened this issue Feb 23, 2018 · 1 comment
Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality performance Excessive resource usage and latency; usually a bug or chore

Comments

@bboreham
Copy link
Collaborator

As noted at #1201 (comment), Docker container labels and environment variables are sent in the Latest structure even though they never change.

We could put them in Sets instead.
@bboreham bboreham added the performance Excessive resource usage and latency; usually a bug or chore label Feb 23, 2018
@bboreham
Copy link
Collaborator Author

Endpoints host_node_id and pid are in the same boat, though it is less obvious that wrapping in Sets will be a win for just two values.

@rade rade added the chore Related to fix/refinement/improvement of end user or new/existing developer functionality label Feb 23, 2018
@2opremio 2opremio added the good-first-issue Indicates a good issue for first-time contributors label May 31, 2018
@bboreham bboreham removed the good-first-issue Indicates a good issue for first-time contributors label Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality performance Excessive resource usage and latency; usually a bug or chore
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rade @2opremio @bboreham