Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced support Metadata template data types [hyperlinks] #3099

Closed
todkap opened this issue Mar 5, 2018 · 3 comments
Closed

Enhanced support Metadata template data types [hyperlinks] #3099

todkap opened this issue Mar 5, 2018 · 3 comments
Labels
component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer feature Indicates that issue is related to new end user functionality

Comments

@todkap
Copy link

todkap commented Mar 5, 2018

In the Metadata template data types, the following is documented

https://www.weave.works/docs/scope/latest/plugins/#report-data-structures
Metadata Templates section

dataType specifies the type of data, and determines how the value is displayed. Possible values for this attribute are: “number”, “ip”, “datetime” and “” for strings.

It would be great if there was support for URLs that support direct linking to resources. The use case is that we have a Node that represents a Deployment of some service. This service exposes a set of links for administration, logging, etc.

Food for thought
If there was a more pluggable extension model, templates could define their own data types backed by the plugin to support other data types as well.

@bboreham bboreham added the feature Indicates that issue is related to new end user functionality label Mar 8, 2018
@bboreham
Copy link
Collaborator

bboreham commented Mar 8, 2018

Hi, thanks for the suggestion!

How do you envisage this would look, both in the code and on the screen?

@sidneyw
Copy link
Contributor

sidneyw commented Mar 8, 2018

Hello,

I work with Todd.

We've implemented the feature by first running a plugin that posts metadata or mulit-column data including the dataType: link field. The frontend then conditionally renders either a link or the original component.

Our implementation is here: #3105

@rade rade added the component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer label Mar 15, 2018
@rade
Copy link
Member

rade commented Apr 2, 2018

Resolved by #3105.

@rade rade closed this as completed Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer feature Indicates that issue is related to new end user functionality
Projects
None yet
Development

No branches or pull requests

4 participants