-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider doing async reverse dns lookups in probe, breaking out the internet node into something more interesting. #364
Comments
Ooh, I like it: we could just tag remote nodes with a variety of whois-y lookup data... "123.45.6.78;80": {
"country": "UK",
"city": "Birmingham",
"owner": "HP Foods LLC"
} |
Other metadata types that could be interesting - geoIP, autonomous system |
Design considerations:
|
For geolocation stuff, it may be better to ship a GeoIP database with every Scope release, rather than pinging some remote service. |
@peterbourgon there are some GeoIP databases publicly available (with some Golang libs). Maybe Scope could download it on the first run and keep it until a new version is available... |
The probes would need to download it, and you may have lots of probes in your infrastructure. If I were an ops guy, I would be very unhappy with a monitoring agent reaching out to the internet and downloading some megabytes from a server when it first boots. I would be very unhappy with it reaching out to the internet at all, actually, unless I explicitly turned some feature on, and understood the implications of doing so. |
@peterbourgon you are right: we should include the GeoIP database in the Scope image. Maybe we could add an option for overriding the embeded database in the future... |
And what about adding this kind of information not in the probe but in the server? The result of geolocating an IP would be the same, and it would be easier to keep an up-to-date database in the server... |
The app server might not be running in the same context as the probes, and might not have access to the same dns (for instance). Lets worry less about geoip for now, and more about reverse dns lookups. |
Yes sorry about that - I didn't mean to pollute this PR, just capture the conversation we had around it the other day... |
Some implementation questions:
|
|
Ok, then I'll start by adding new nodes in |
Done |
Esp when running apps in the cloud, would be nice to show which components are calling out to which services (s3, ses, etc)
The text was updated successfully, but these errors were encountered: