Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic running master against service #792

Closed
tomwilkie opened this issue Jan 4, 2016 · 1 comment
Closed

Panic running master against service #792

tomwilkie opened this issue Jan 4, 2016 · 1 comment
Assignees
Labels
bug Broken end user or developer functionality; not working as the developers intended it
Milestone

Comments

@tomwilkie
Copy link
Contributor

Reported in #785:

goroutine 46 [running]:
github.com/weaveworks/scope/xfer.(*JSONWebsocketCodec).ReadRequestHeader(0xc8202afe00, 0xc8202afe20, 0x0, 0x0)
        /go/src/github.com/weaveworks/scope/xfer/controls.go:143 +0xa7
net/rpc.(*Server).readRequestHeader(0xc8208eff40, 0x7fa207562820, 0xc8202afe00, 0x0, 0x0, 0xc8202afe20, 0x41ae00, 0x0, 0x0)
        /usr/local/go/src/net/rpc/server.go:576 +0x90
net/rpc.(*Server).readRequest(0xc8208eff40, 0x7fa207562820, 0xc8202afe00, 0xc8206fe180, 0x416f1e, 0x1e1b230, 0x0, 0x0, 0x0, 0x0, ...)
        /usr/local/go/src/net/rpc/server.go:543 +0x8b
net/rpc.(*Server).ServeCodec(0xc8208eff40, 0x7fa207562820, 0xc8202afe00)
        /usr/local/go/src/net/rpc/server.go:462 +0x8c
github.com/weaveworks/scope/xfer.(*appClient).controlConnection(0xc82011eb00, 0x4f9700, 0x0, 0x0)
        /go/src/github.com/weaveworks/scope/xfer/app_client.go:217 +0x482
github.com/weaveworks/scope/xfer.(*appClient).(github.com/weaveworks/scope/xfer.controlConnection)-fm(0xc800000008, 0x0, 0x0)
        /go/src/github.com/weaveworks/scope/xfer/app_client.go:225 +0x2e
github.com/weaveworks/scope/xfer.(*appClient).doWithBackoff(0xc82011eb00, 0x1397400, 0x8, 0xc82011bf58)
        /go/src/github.com/weaveworks/scope/xfer/app_client.go:170 +0x9e
github.com/weaveworks/scope/xfer.(*appClient).ControlConnection.func1(0xc82011eb00)
        /go/src/github.com/weaveworks/scope/xfer/app_client.go:225 +0x22d
created by github.com/weaveworks/scope/xfer.(*appClient).ControlConnection
        /go/src/github.com/weaveworks/scope/xfer/app_client.go:226 +0x35
@tomwilkie tomwilkie self-assigned this Jan 4, 2016
@tomwilkie
Copy link
Contributor Author

My bad; the intention was the the controls would be backward compatible, but this change was left in from an old prototype of pipes that used the same ws for pipe IOs.

Its hard to think of a way of supporting both versions here - I'll give it a go, but we might just have to fix the panic and accept that controls are broken v10 <-> v11.

@tomwilkie tomwilkie added the bug Broken end user or developer functionality; not working as the developers intended it label Jan 4, 2016
@tomwilkie tomwilkie added this to the 0.12.0 milestone Jan 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Broken end user or developer functionality; not working as the developers intended it
Projects
None yet
Development

No branches or pull requests

1 participant