Have the probe fill in the app id, not the app

[tomwilkie]

Fixes #1085

[2opremio]

I've done some testing and unfortunately this is not enough to fix #1085

There are two additional problems:

• The first pipe request (GET) is not correctly prefixed. @davkal can you please take a look at this? Also, is there a reason make the second (websocket) request even if the first request didn't succeed?
• The first pipe request (GET) uses the same endpoint as the second (websocket) request, I discussed this offline with @tomwilkie. This causes a conflict in the nginx configuration since websockets need special treatment (adding an upgrade header in the forwarded request etc ...) . We could have different location rules based on the request type but it's hacky http://stackoverflow.com/questions/8591600/nginx-proxy-pass-based-on-whether-request-method-is-post-put-or-delete

Finally, @tomwilkie , since this is blocking upgrading the service and requires cutting a new release (0.13.1), would you mind re-creating this pull request against a release branch forked from v0.13.0?

[tomwilkie]

Sounds like a plan. Let's make this top priority for tomorrow.

@foot is the man you want for ui pipes.

On Wednesday, 2 March 2016, Alfonso Acosta notifications@github.com wrote:

I've done some testing and this is not enough to fix #1085
#1085

[image: screen shot 2016-03-02 at 7 23 07 pm]
https://cloud.githubusercontent.com/assets/2362916/13472358/7153c22c-e0ac-11e5-9a1a-0a1ff0c1a850.png

There are two additional problems:

• The first pipe request (GET) is not correctly prefixed. @davkal
  https://github.com/davkal can you please take a look at this? Also,
  is there a reason make the second (websocket) request even if the first
  request didn't succeed?
• The first pipe request (GET) uses the same endpoint as the second
  (websocket) request, I discussed this offline with @tomwilkie
  https://github.com/tomwilkie. This causes a conflict in the nginx
  configuration since websockets need special treatment (adding an upgrade
  header in the forwarded request etc ...) . We could have different location
  rules based on the request type but it's hacky
  http://stackoverflow.com/questions/8591600/nginx-proxy-pass-based-on-whether-request-method-is-post-put-or-delete

Finally, @tomwilkie https://github.com/tomwilkie , since this is
blocking upgrading the service and requires cutting a new release (0.13.1),
would you mind re-creating a pull request against a release branch forked
from v0.13.0?

—
Reply to this email directly or view it on GitHub
#1086 (comment).