Various websocket and pipe fixes. #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tomwilkie
commented
Mar 15, 2016
tomwilkie
commented
- return 404 from /api/pipe/foo/check when pipe is not found, 204 when it is
- ensure the websocket pinger is shutdown correctly
- return the response when a websocket dial returns 404, so the probe knows to stop (fixes Probe hammers app with pipe requests after deletion failure #1114)
| @@ -78,6 +86,16 @@ func NewLocalPipeRouter() PipeRouter { | |||
| return pipeRouter | |||
| } | |||
|
|
|||
| func (pr *localPipeRouter) Exists(_ context.Context, id string) (bool, error) { | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
LGTM |
tomwilkie
added a commit
that referenced
this pull request
Mar 15, 2016
Various websocket and pipe fixes.
| 200: 'PIPE_ALIVE', | ||
| 204: 'PIPE_DELETED' | ||
| 204: 'PIPE_ALIVE', | ||
| 404: 'PIPE_DELETED' |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This was referenced Mar 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.